From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail7.windriver.com (mail7.windriver.com [128.224.252.3]) by mail.openembedded.org (Postfix) with ESMTP id 25C4D60698 for ; Fri, 16 Aug 2013 08:44:07 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail7.windriver.com (8.14.5/8.14.3) with ESMTP id r7G8i5Nn016554 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 16 Aug 2013 04:44:06 -0400 (EDT) Received: from [128.224.162.168] (128.224.162.168) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.342.3; Fri, 16 Aug 2013 01:44:05 -0700 Message-ID: <520DE65C.5050807@windriver.com> Date: Fri, 16 Aug 2013 16:44:12 +0800 From: Rongqing Li User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: References: <1376619839-23232-1-git-send-email-rongqing.li@windriver.com> <20130816071954.GG17945@jama> In-Reply-To: <20130816071954.GG17945@jama> Cc: joe.macdonald@windriver.com Subject: Re: [PATCH meta-networking] quagga: two fixes X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2013 08:44:10 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 08/16/2013 03:19 PM, Martin Jansa wrote: > On Fri, Aug 16, 2013 at 10:23:59AM +0800, rongqing.li@windriver.com wrote: >> From: "Roy.Li" >> >> 1. quagga should depend on iproute2, since ip from busybox is not sufficient >> 2. fix a typOS(should chmod, not chown) > > As you care about quagga, can you please fix: > quagga-0.99.21: The /usr/share/info/dir file is not meant to be shipped > in a particular package. > > ? I did not see this warning, and this file is shipped to quagga-doc. If there is difference, it is in oe-core, not quagga -Roy > > Thanks > >> >> Signed-off-by: Roy.Li >> --- >> meta-networking/recipes-protocols/quagga/quagga.inc | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/meta-networking/recipes-protocols/quagga/quagga.inc b/meta-networking/recipes-protocols/quagga/quagga.inc >> index f5489c6..89b9f7a 100644 >> --- a/meta-networking/recipes-protocols/quagga/quagga.inc >> +++ b/meta-networking/recipes-protocols/quagga/quagga.inc >> @@ -5,7 +5,7 @@ Unix platforms, particularly FreeBSD, Linux, Solaris and NetBSD. \ >> Quagga is a fork of GNU Zebra which was developed by Kunihiro \ >> Ishiguro. The Quagga tree aims to build a more involved community \ >> around Quagga than the current centralised model of GNU Zebra." >> -HOMEPAGE = "http://www.quagga.net/" >> +HOMEPAGE = "http://www.nongnu.org/quagga/" >> SECTION = "network" >> LICENSE = "GPL-2.0 & LGPL-2.0" >> DEPENDS = "readline ncurses perl-native" >> @@ -17,6 +17,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \ >> >> INC_PR = "r2" >> >> +# the "ip" command from busybox is not sufficient (flush by protocol flushes all routes) >> +RDEPENDS_${PN} += "iproute2" >> + >> QUAGGASUBDIR = "" >> # ${QUAGGASUBDIR} is deal with old versions. Set to "/attic" for old >> # versions and leave it empty for recent versions. >> @@ -128,11 +131,11 @@ pkg_postinst_${PN} () { >> if [ "x$D" != "x" ] ; then >> exit 1 >> fi >> - for f in bgpd babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done >> + for f in bgpd vtysh babeld isisd ospfd ripngd zebra ripd ospf6d; do touch ${sysconfdir}/quagga/$f.conf; done >> chown quagga:quaggavty ${sysconfdir}/quagga >> chown quagga:quagga ${sysconfdir}/quagga/*.conf >> chmod 750 ${sysconfdir}/quagga >> - chown 640 ${sysconfdir}/quagga/*.conf >> + chmod 640 ${sysconfdir}/quagga/*.conf >> if [ -z "$D" ] && [ -e /etc/init.d/populate-volatile.sh ] ; then >> ${sysconfdir}/init.d/populate-volatile.sh update >> fi >> -- >> 1.7.10.4 >> >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel > -- Best Reagrds, Roy | RongQing Li