From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VAKBP-00089h-7c for qemu-devel@nongnu.org; Fri, 16 Aug 2013 09:35:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VAKBJ-0003AL-36 for qemu-devel@nongnu.org; Fri, 16 Aug 2013 09:35:15 -0400 Message-ID: <520E2B1F.6010109@redhat.com> Date: Fri, 16 Aug 2013 15:37:35 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <20130816124915.12577.72732.stgit@bling.home> In-Reply-To: <20130816124915.12577.72732.stgit@bling.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] exec: Fix non-power-of-2 sized accesses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: rth@twiddle.net, qemu-devel@nongnu.org, qemu-stable@nongnu.org On 08/16/13 14:50, Alex Williamson wrote: > Since commit 23326164 we align access sizes to match the alignment of > the address, but we don't align the access size itself. This means we > let illegal access sizes (ex. 3) slip through if the address is > sufficiently aligned (ex. 4). This results in an abort which would be > easy for a guest to trigger. Account for aligning the access size. > > Signed-off-by: Alex Williamson > Cc: qemu-stable@nongnu.org > Reviewed-by: Laszlo Ersek yeah > --- > > v2: Remove unnecessary loop condition > > exec.c | 7 +++++++ > 1 file changed, 7 insertions(+)