From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH RFC 3/3] spmi: document the PMIC arbiter SPMI bindings Date: Fri, 16 Aug 2013 17:17:18 -0600 Message-ID: <520EB2FE.2030903@wwwdotorg.org> References: <20130816192549.GG4035@joshc.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kumar Gala Cc: Mark Rutland , devicetree@vger.kernel.org, Ian Campbell , Pawel Moll , Greg Kroah-Hartman , Josh Cartwright , Gilad Avidov , linux-kernel@vger.kernel.org, Rob Herring , Michael Bohan , linux-arm-msm@vger.kernel.org, Grant Likely , Sagar Dharia , linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org On 08/16/2013 01:48 PM, Kumar Gala wrote: > > On Aug 16, 2013, at 2:25 PM, Josh Cartwright wrote: > >> Hey Kumar- >> >> Thanks for the review. >> >> On Fri, Aug 16, 2013 at 01:53:27PM -0500, Kumar Gala wrote: >>> On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote: >>> >>>> Signed-off-by: Josh Cartwright >>>> --- >>>> .../devicetree/bindings/spmi/spmi-pmic-arb.txt | 26 ++++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/spmi/spmi-pmic-arb.txt >>> >>> As this is a qcom specific binding, I think the file name should be msm-spmi-pmic-arb.txt or something like that. >> >> Agreed. It might be nice to use a vendor prefix in the name too. How's qcom,msm-pmic-arb.txt sound? > > Sounds good, as I see we have other examples of having a comma in file names for bindings. The rule I've applied for bindings I created is use the complete compatible value for the file name. Where multiple are supported (e.g. SoC versions), just use the first one. Then, the filename is pretty unambiguous, both from a point of view of `ls` and from choosing a name. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757078Ab3HQAdO (ORCPT ); Fri, 16 Aug 2013 20:33:14 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:54050 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756377Ab3HQAdI (ORCPT ); Fri, 16 Aug 2013 20:33:08 -0400 Message-ID: <520EB2FE.2030903@wwwdotorg.org> Date: Fri, 16 Aug 2013 17:17:18 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Kumar Gala CC: Josh Cartwright , Grant Likely , Rob Herring , Greg Kroah-Hartman , Pawel Moll , Mark Rutland , Ian Campbell , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Sagar Dharia , Gilad Avidov , Michael Bohan , devicetree@vger.kernel.org Subject: Re: [PATCH RFC 3/3] spmi: document the PMIC arbiter SPMI bindings References: <20130816192549.GG4035@joshc.qualcomm.com> In-Reply-To: X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16/2013 01:48 PM, Kumar Gala wrote: > > On Aug 16, 2013, at 2:25 PM, Josh Cartwright wrote: > >> Hey Kumar- >> >> Thanks for the review. >> >> On Fri, Aug 16, 2013 at 01:53:27PM -0500, Kumar Gala wrote: >>> On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote: >>> >>>> Signed-off-by: Josh Cartwright >>>> --- >>>> .../devicetree/bindings/spmi/spmi-pmic-arb.txt | 26 ++++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/spmi/spmi-pmic-arb.txt >>> >>> As this is a qcom specific binding, I think the file name should be msm-spmi-pmic-arb.txt or something like that. >> >> Agreed. It might be nice to use a vendor prefix in the name too. How's qcom,msm-pmic-arb.txt sound? > > Sounds good, as I see we have other examples of having a comma in file names for bindings. The rule I've applied for bindings I created is use the complete compatible value for the file name. Where multiple are supported (e.g. SoC versions), just use the first one. Then, the filename is pretty unambiguous, both from a point of view of `ls` and from choosing a name. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Fri, 16 Aug 2013 17:17:18 -0600 Subject: [PATCH RFC 3/3] spmi: document the PMIC arbiter SPMI bindings In-Reply-To: References: <20130816192549.GG4035@joshc.qualcomm.com> Message-ID: <520EB2FE.2030903@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/16/2013 01:48 PM, Kumar Gala wrote: > > On Aug 16, 2013, at 2:25 PM, Josh Cartwright wrote: > >> Hey Kumar- >> >> Thanks for the review. >> >> On Fri, Aug 16, 2013 at 01:53:27PM -0500, Kumar Gala wrote: >>> On Aug 9, 2013, at 3:37 PM, Josh Cartwright wrote: >>> >>>> Signed-off-by: Josh Cartwright >>>> --- >>>> .../devicetree/bindings/spmi/spmi-pmic-arb.txt | 26 ++++++++++++++++++++++ >>>> 1 file changed, 26 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/spmi/spmi-pmic-arb.txt >>> >>> As this is a qcom specific binding, I think the file name should be msm-spmi-pmic-arb.txt or something like that. >> >> Agreed. It might be nice to use a vendor prefix in the name too. How's qcom,msm-pmic-arb.txt sound? > > Sounds good, as I see we have other examples of having a comma in file names for bindings. The rule I've applied for bindings I created is use the complete compatible value for the file name. Where multiple are supported (e.g. SoC versions), just use the first one. Then, the filename is pretty unambiguous, both from a point of view of `ls` and from choosing a name.