From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D69D6C433B4 for ; Wed, 12 May 2021 09:52:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91669613C1 for ; Wed, 12 May 2021 09:52:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhELJxp (ORCPT ); Wed, 12 May 2021 05:53:45 -0400 Received: from pegase2.c-s.fr ([93.17.235.10]:43843 "EHLO pegase2.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230097AbhELJxp (ORCPT ); Wed, 12 May 2021 05:53:45 -0400 Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Fg97m2Xyjz9sfB; Wed, 12 May 2021 11:52:36 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SyOMJlBUQJTV; Wed, 12 May 2021 11:52:36 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Fg97m1VNCz9sf8; Wed, 12 May 2021 11:52:36 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 73E1F8B7DF; Wed, 12 May 2021 11:52:35 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id uE-bovAzgLkj; Wed, 12 May 2021 11:52:35 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id AA6DF8B7E8; Wed, 12 May 2021 11:52:32 +0200 (CEST) Subject: Re: arch/powerpc/kernel/optprobes.c:34:1: error: unused function 'is_kprobe_ppc_optinsn_slot' From: Christophe Leroy To: Nathan Chancellor , kernel test robot , Nick Desaulniers , Masahiro Yamada , Masami Hiramatsu Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Michael Ellerman References: <202105120059.uTLH58Lm-lkp@intel.com> <48747467-cb93-c66d-4cf9-097be0568488@csgroup.eu> <208186f3-aab0-d94e-bcf4-8347983cc1a6@kernel.org> <0885f8b8-fea5-3fb0-42d7-b73e862a8c47@csgroup.eu> Message-ID: <520bd3e7-ddee-bbee-0735-6aad29acb5bb@csgroup.eu> Date: Wed, 12 May 2021 11:52:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <0885f8b8-fea5-3fb0-42d7-b73e862a8c47@csgroup.eu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 12/05/2021 à 11:36, Christophe Leroy a écrit : > > > Le 11/05/2021 à 20:46, Nathan Chancellor a écrit : >> On 5/11/2021 9:47 AM, Christophe Leroy wrote: >>> Hi All, >>> >>> Le 11/05/2021 à 18:30, kernel test robot a écrit : >>>> Hi Christophe, >>>> >>>> First bad commit (maybe != root cause): >>>> >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>>> head:   1140ab592e2ebf8153d2b322604031a8868ce7a5 >>>> commit: eacf4c0202654adfa94bbb17b5c5c77c0be14af8 powerpc: Enable OPTPROBES on PPC32 > > Ok, the problem appears on PPC32 with that patch, but it must have been there on PPC64 since the > implementation of optprobes with commit 51c9c0843993 ("powerpc/kprobes: Implement Optprobes") > > >>>> date:   3 weeks ago >>>> config: powerpc-randconfig-r033-20210511 (attached as .config) >>>> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project >>>> a0fed635fe1701470062495a6ffee1c608f3f1bc) >>> >>> A clang issue ? >>> >>> >>>> reproduce (this is a W=1 build): >>>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O >>>> ~/bin/make.cross >>>>          chmod +x ~/bin/make.cross >>>>          # install powerpc cross compiling tool for clang build >>>>          # apt-get install binutils-powerpc-linux-gnu >>>>          # >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=eacf4c0202654adfa94bbb17b5c5c77c0be14af8 >>>> >>>>          git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >>>>          git fetch --no-tags linus master >>>>          git checkout eacf4c0202654adfa94bbb17b5c5c77c0be14af8 >>>>          # save the attached .config to linux build tree >>>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=powerpc >>>> >>>> If you fix the issue, kindly add following tag as appropriate >>>> Reported-by: kernel test robot >>>> >>>> All errors (new ones prefixed by >>): >>>> >>>>>> arch/powerpc/kernel/optprobes.c:34:1: error: unused function 'is_kprobe_ppc_optinsn_slot' >>>>>> [-Werror,-Wunused-function] >>>>     DEFINE_INSN_CACHE_OPS(ppc_optinsn); >>>>     ^ >>>>     include/linux/kprobes.h:306:20: note: expanded from macro 'DEFINE_INSN_CACHE_OPS' >>>>     static inline bool is_kprobe_##__name##_slot(unsigned long addr)        \ >>> >>> That's a 'static inline', shouldn't generate an 'unused function' warning. >> This is a W=1 build, which means that "inline" does not silence unused function warnings with >> clang because of commit 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions >> for W=1 build"). > > Ok, I didn't know that. After looking at it in more details, I don't really know what should be done to avoid that. This unused function is defined as part of DEFINE_INSN_CACHE_OPS(ppc_optinsn). The code uses other items defined by macro DEFINE_INSN_CACHE_OPS, so it cannot be removed. Solution could be to hide that in a .h, but is that worth it ? It can't go in asm/kprobes.h because linux/kprobes.h includes asm/kprobes.h before defining DEFINE_INSN_CACHE_OPS(). So it would mean a dedicated header just for hiding the problem under the carpet. > >> >> Cheers, >> Nathan >> >>>>                        ^ >>>>     :16:1: note: expanded from here >>>>     is_kprobe_ppc_optinsn_slot >>>>     ^ >>>>     1 error generated. >>>> >>>> >>>> vim +/is_kprobe_ppc_optinsn_slot +34 arch/powerpc/kernel/optprobes.c >>>> >>>> 51c9c084399352 Anju T 2017-02-08  20 >>>> 51c9c084399352 Anju T 2017-02-08  21  #define TMPL_CALL_HDLR_IDX    \ >>>> 51c9c084399352 Anju T 2017-02-08  22 (optprobe_template_call_handler - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08  23  #define TMPL_EMULATE_IDX    \ >>>> 51c9c084399352 Anju T 2017-02-08  24 (optprobe_template_call_emulate - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08  25  #define TMPL_RET_IDX        \ >>>> 51c9c084399352 Anju T 2017-02-08  26      (optprobe_template_ret - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08  27  #define TMPL_OP_IDX        \ >>>> 51c9c084399352 Anju T 2017-02-08  28 (optprobe_template_op_address - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08  29  #define TMPL_INSN_IDX        \ >>>> 51c9c084399352 Anju T 2017-02-08  30      (optprobe_template_insn - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08  31  #define TMPL_END_IDX        \ >>>> 51c9c084399352 Anju T 2017-02-08  32      (optprobe_template_end - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08  33 >>>> 51c9c084399352 Anju T 2017-02-08 @34  DEFINE_INSN_CACHE_OPS(ppc_optinsn); >>>> 51c9c084399352 Anju T 2017-02-08  35 >>>> >>>> :::::: The code at line 34 was first introduced by commit >>>> :::::: 51c9c0843993528bffc920c54c2121d9e6f8b090 powerpc/kprobes: Implement Optprobes >>>> >>>> :::::: TO: Anju T >>>> :::::: CC: Michael Ellerman >>>> >>>> --- >>>> 0-DAY CI Kernel Test Service, Intel Corporation >>>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >>>> >>> From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8556077076874934176==" MIME-Version: 1.0 From: Christophe Leroy To: kbuild-all@lists.01.org Subject: Re: arch/powerpc/kernel/optprobes.c:34:1: error: unused function 'is_kprobe_ppc_optinsn_slot' Date: Wed, 12 May 2021 11:52:30 +0200 Message-ID: <520bd3e7-ddee-bbee-0735-6aad29acb5bb@csgroup.eu> In-Reply-To: <0885f8b8-fea5-3fb0-42d7-b73e862a8c47@csgroup.eu> List-Id: --===============8556077076874934176== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Le 12/05/2021 =C3=A0 11:36, Christophe Leroy a =C3=A9crit=C2=A0: > = > = > Le 11/05/2021 =C3=A0 20:46, Nathan Chancellor a =C3=A9crit=C2=A0: >> On 5/11/2021 9:47 AM, Christophe Leroy wrote: >>> Hi All, >>> >>> Le 11/05/2021 =C3=A0 18:30, kernel test robot a =C3=A9crit=C2=A0: >>>> Hi Christophe, >>>> >>>> First bad commit (maybe !=3D root cause): >>>> >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g= it master >>>> head:=C2=A0=C2=A0 1140ab592e2ebf8153d2b322604031a8868ce7a5 >>>> commit: eacf4c0202654adfa94bbb17b5c5c77c0be14af8 powerpc: Enable OPTPR= OBES on PPC32 > = > Ok, the problem appears on PPC32 with that patch, but it must have been t= here on PPC64 since the = > implementation of optprobes with commit 51c9c0843993 ("powerpc/kprobes: I= mplement Optprobes") > = > = >>>> date:=C2=A0=C2=A0 3 weeks ago >>>> config: powerpc-randconfig-r033-20210511 (attached as .config) >>>> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project = >>>> a0fed635fe1701470062495a6ffee1c608f3f1bc) >>> >>> A clang issue ? >>> >>> >>>> reproduce (this is a W=3D1 build): >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 wget https://raw.gith= ubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O = >>>> ~/bin/make.cross >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 chmod +x ~/bin/make.c= ross >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # install powerpc cro= ss compiling tool for clang build >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # apt-get install bin= utils-powerpc-linux-gnu >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # = >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/com= mit/?id=3Deacf4c0202654adfa94bbb17b5c5c77c0be14af8 = >>>> >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git remote add linus = https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git fetch --no-tags l= inus master >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git checkout eacf4c02= 02654adfa94bbb17b5c5c77c0be14af8 >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # save the attached .= config to linux build tree >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 COMPILER_INSTALL_PATH= =3D$HOME/0day COMPILER=3Dclang make.cross W=3D1 ARCH=3Dpowerpc >>>> >>>> If you fix the issue, kindly add following tag as appropriate >>>> Reported-by: kernel test robot >>>> >>>> All errors (new ones prefixed by >>): >>>> >>>>>> arch/powerpc/kernel/optprobes.c:34:1: error: unused function 'is_kpr= obe_ppc_optinsn_slot' = >>>>>> [-Werror,-Wunused-function] >>>> =C2=A0=C2=A0=C2=A0 DEFINE_INSN_CACHE_OPS(ppc_optinsn); >>>> =C2=A0=C2=A0=C2=A0 ^ >>>> =C2=A0=C2=A0=C2=A0 include/linux/kprobes.h:306:20: note: expanded from= macro 'DEFINE_INSN_CACHE_OPS' >>>> =C2=A0=C2=A0=C2=A0 static inline bool is_kprobe_##__name##_slot(unsign= ed long addr)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>> >>> That's a 'static inline', shouldn't generate an 'unused function' warni= ng. >> This is a W=3D1 build, which means that "inline" does not silence unused= function warnings with = >> clang because of commit 6863f5643dd7 ("kbuild: allow Clang to find unuse= d static inline functions = >> for W=3D1 build"). > = > Ok, I didn't know that. After looking at it in more details, I don't really know what should be don= e to avoid that. This unused function is defined as part of DEFINE_INSN_CACHE_OPS(ppc_optins= n). The code uses other items defined by macro DEFINE_INSN_CACHE_OPS, so it can= not be removed. Solution could be to hide that in a .h, but is that worth it ? It can't go in asm/kprobes.h because linux/kprobes.h includes asm/kprobes.h= before defining = DEFINE_INSN_CACHE_OPS(). So it would mean a dedicated header just for hidin= g the problem under the = carpet. > = >> >> Cheers, >> Nathan >> >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ >>>> =C2=A0=C2=A0=C2=A0 :16:1: note: expanded from here >>>> =C2=A0=C2=A0=C2=A0 is_kprobe_ppc_optinsn_slot >>>> =C2=A0=C2=A0=C2=A0 ^ >>>> =C2=A0=C2=A0=C2=A0 1 error generated. >>>> >>>> >>>> vim +/is_kprobe_ppc_optinsn_slot +34 arch/powerpc/kernel/optprobes.c >>>> >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 20 >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 21=C2=A0 #define TMPL_CALL_HDLR= _IDX=C2=A0=C2=A0=C2=A0 \ >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 22 (optprobe_template_call_hand= ler - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 23=C2=A0 #define TMPL_EMULATE_I= DX=C2=A0=C2=A0=C2=A0 \ >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 24 (optprobe_template_call_emul= ate - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 25=C2=A0 #define TMPL_RET_IDX= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 26=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 (optprobe_template_ret - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 27=C2=A0 #define TMPL_OP_IDX=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 28 (optprobe_template_op_addres= s - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 29=C2=A0 #define TMPL_INSN_IDX= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 30=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 (optprobe_template_insn - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 31=C2=A0 #define TMPL_END_IDX= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 \ >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 32=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 (optprobe_template_end - optprobe_template_entry) >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 33 >>>> 51c9c084399352 Anju T 2017-02-08 @34=C2=A0 DEFINE_INSN_CACHE_OPS(ppc_o= ptinsn); >>>> 51c9c084399352 Anju T 2017-02-08=C2=A0 35 >>>> >>>> :::::: The code at line 34 was first introduced by commit >>>> :::::: 51c9c0843993528bffc920c54c2121d9e6f8b090 powerpc/kprobes: Imple= ment Optprobes >>>> >>>> :::::: TO: Anju T >>>> :::::: CC: Michael Ellerman >>>> >>>> --- >>>> 0-DAY CI Kernel Test Service, Intel Corporation >>>> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org >>>> >>> --===============8556077076874934176==--