* Re: [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c
[not found] <5c2e6965.1c69fb81.b832c.13ee@mx.google.com>
@ 2019-01-09 10:15 ` Laurent Vivier
2019-01-11 0:37 ` David Gibson
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Vivier @ 2019-01-09 10:15 UTC (permalink / raw)
To: Jon Diekema, QEMU Developers, David Gibson, qemu-ppc; +Cc: qemu-trivial
Hi Jon,
please cc: qemu-devel and MAINTAINERS when you send a patch.
You can have the list of maintainers using a script in qemu directory:
./scripts/get_maintainer.pl XXXX.patch
Thanks,
Laurent
On 03/01/2019 20:58, Jon Diekema wrote:
> From: Jon Diekema <jon.diekema@gmail.com>
> Date: Tue, 25 Dec 2018 04:03:04 -0500
> Subject: Whitespace cleanup: target/ppc/translate_init.inc.c
>
> Signed-off-by: Jon Diekema <jon.diekema@gmail.com>
> ---
> target/ppc/translate_init.inc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c
> index c971a5faf7..b5f4c9bd55 100644
> --- a/target/ppc/translate_init.inc.c
> +++ b/target/ppc/translate_init.inc.c
> @@ -5237,7 +5237,7 @@ static void init_proc_601(CPUPPCState *env)
> 0x00000000);
> /* Memory management */
> init_excp_601(env);
> - /* XXX: beware that dcache line size is 64
> + /* XXX: beware that dcache line size is 64
> * but dcbz uses 32 bytes "sectors"
> * XXX: this breaks clcs instruction !
> */
> @@ -10485,7 +10485,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, void *data)
> cc->tcg_initialize = ppc_translate_init;
> #endif
> cc->disas_set_info = ppc_disas_set_info;
> -
> +
> dc->fw_name = "PowerPC,UNKNOWN";
> }
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c
2019-01-09 10:15 ` [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c Laurent Vivier
@ 2019-01-11 0:37 ` David Gibson
2019-01-11 7:20 ` Laurent Vivier
0 siblings, 1 reply; 5+ messages in thread
From: David Gibson @ 2019-01-11 0:37 UTC (permalink / raw)
To: Laurent Vivier; +Cc: Jon Diekema, QEMU Developers, qemu-ppc, qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 1970 bytes --]
On Wed, Jan 09, 2019 at 11:15:26AM +0100, Laurent Vivier wrote:
> Hi Jon,
>
> please cc: qemu-devel and MAINTAINERS when you send a patch.
>
> You can have the list of maintainers using a script in qemu directory:
>
> ./scripts/get_maintainer.pl XXXX.patch
>
> Thanks,
> Laurent
Hrm. Like the other patch, I didn't seem to receive this - I checked
back through my archives. I think something must be not working with
email from Jon to me, although I can't quite imagine what.
>
> On 03/01/2019 20:58, Jon Diekema wrote:
> > From: Jon Diekema <jon.diekema@gmail.com>
> > Date: Tue, 25 Dec 2018 04:03:04 -0500
> > Subject: Whitespace cleanup: target/ppc/translate_init.inc.c
> >
> > Signed-off-by: Jon Diekema <jon.diekema@gmail.com>
> > ---
> > target/ppc/translate_init.inc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c
> > index c971a5faf7..b5f4c9bd55 100644
> > --- a/target/ppc/translate_init.inc.c
> > +++ b/target/ppc/translate_init.inc.c
> > @@ -5237,7 +5237,7 @@ static void init_proc_601(CPUPPCState *env)
> > 0x00000000);
> > /* Memory management */
> > init_excp_601(env);
> > - /* XXX: beware that dcache line size is 64
> > + /* XXX: beware that dcache line size is 64
> > * but dcbz uses 32 bytes "sectors"
> > * XXX: this breaks clcs instruction !
> > */
> > @@ -10485,7 +10485,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, void *data)
> > cc->tcg_initialize = ppc_translate_init;
> > #endif
> > cc->disas_set_info = ppc_disas_set_info;
> > -
> > +
> > dc->fw_name = "PowerPC,UNKNOWN";
> > }
> >
> >
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c
2019-01-11 0:37 ` David Gibson
@ 2019-01-11 7:20 ` Laurent Vivier
2019-01-11 13:05 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 5+ messages in thread
From: Laurent Vivier @ 2019-01-11 7:20 UTC (permalink / raw)
To: David Gibson; +Cc: qemu-trivial, qemu-ppc, Jon Diekema, QEMU Developers
On 11/01/2019 01:37, David Gibson wrote:
> On Wed, Jan 09, 2019 at 11:15:26AM +0100, Laurent Vivier wrote:
>> Hi Jon,
>>
>> please cc: qemu-devel and MAINTAINERS when you send a patch.
>>
>> You can have the list of maintainers using a script in qemu directory:
>>
>> ./scripts/get_maintainer.pl XXXX.patch
>>
>> Thanks,
>> Laurent
>
> Hrm. Like the other patch, I didn't seem to receive this - I checked
> back through my archives. I think something must be not working with
> email from Jon to me, although I can't quite imagine what.
>
>>
>> On 03/01/2019 20:58, Jon Diekema wrote:
>>> From: Jon Diekema <jon.diekema@gmail.com>
>>> Date: Tue, 25 Dec 2018 04:03:04 -0500
>>> Subject: Whitespace cleanup: target/ppc/translate_init.inc.c
>>>
>>> Signed-off-by: Jon Diekema <jon.diekema@gmail.com>
>>> ---
>>> target/ppc/translate_init.inc.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/target/ppc/translate_init.inc.c b/target/ppc/translate_init.inc.c
>>> index c971a5faf7..b5f4c9bd55 100644
>>> --- a/target/ppc/translate_init.inc.c
>>> +++ b/target/ppc/translate_init.inc.c
>>> @@ -5237,7 +5237,7 @@ static void init_proc_601(CPUPPCState *env)
>>> 0x00000000);
>>> /* Memory management */
>>> init_excp_601(env);
>>> - /* XXX: beware that dcache line size is 64
>>> + /* XXX: beware that dcache line size is 64
>>> * but dcbz uses 32 bytes "sectors"
>>> * XXX: this breaks clcs instruction !
>>> */
>>> @@ -10485,7 +10485,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, void *data)
>>> cc->tcg_initialize = ppc_translate_init;
>>> #endif
>>> cc->disas_set_info = ppc_disas_set_info;
>>> -
>>> +
>>> dc->fw_name = "PowerPC,UNKNOWN";
>>> }
>>>
>>>
>>
>
Likewise. Only sent to qemu-trivial ML.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c
2019-01-11 7:20 ` Laurent Vivier
@ 2019-01-11 13:05 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-11 13:05 UTC (permalink / raw)
To: Laurent Vivier, David Gibson
Cc: qemu-trivial, qemu-ppc, Jon Diekema, QEMU Developers
On 1/11/19 8:20 AM, Laurent Vivier wrote:
> On 11/01/2019 01:37, David Gibson wrote:
>> On Wed, Jan 09, 2019 at 11:15:26AM +0100, Laurent Vivier wrote:
>>> Hi Jon,
>>>
>>> please cc: qemu-devel and MAINTAINERS when you send a patch.
>>>
>>> You can have the list of maintainers using a script in qemu directory:
>>>
>>> ./scripts/get_maintainer.pl XXXX.patch
>>>
>>> Thanks,
>>> Laurent
>>
>> Hrm. Like the other patch, I didn't seem to receive this - I checked
>> back through my archives. I think something must be not working with
>> email from Jon to me, although I can't quite imagine what.
>>
>>>
>>> On 03/01/2019 20:58, Jon Diekema wrote:
>>>> From: Jon Diekema <jon.diekema@gmail.com>
>>>> Date: Tue, 25 Dec 2018 04:03:04 -0500
>>>> Subject: Whitespace cleanup: target/ppc/translate_init.inc.c
>>>>
>>>> Signed-off-by: Jon Diekema <jon.diekema@gmail.com>
>>>> ---
>>>> target/ppc/translate_init.inc.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/target/ppc/translate_init.inc.c
>>>> b/target/ppc/translate_init.inc.c
>>>> index c971a5faf7..b5f4c9bd55 100644
>>>> --- a/target/ppc/translate_init.inc.c
>>>> +++ b/target/ppc/translate_init.inc.c
>>>> @@ -5237,7 +5237,7 @@ static void init_proc_601(CPUPPCState *env)
>>>> 0x00000000);
>>>> /* Memory management */
>>>> init_excp_601(env);
>>>> - /* XXX: beware that dcache line size is 64
>>>> + /* XXX: beware that dcache line size is 64
>>>> * but dcbz uses 32 bytes "sectors"
>>>> * XXX: this breaks clcs instruction !
>>>> */
>>>> @@ -10485,7 +10485,7 @@ static void ppc_cpu_class_init(ObjectClass
>>>> *oc, void *data)
>>>> cc->tcg_initialize = ppc_translate_init;
>>>> #endif
>>>> cc->disas_set_info = ppc_disas_set_info;
>>>> -
>>>> +
>>>> dc->fw_name = "PowerPC,UNKNOWN";
>>>> }
>>>>
>>>
>>
>
> Likewise. Only sent to qemu-trivial ML.
Also tools like patchew are only subscribed to qemu-devel@nongnu.org, so
this patch is missing there too.
The documentation seems clear enough although:
- README:
Submitting patches
==================
When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. [...]
- MAINTAINERS
All patches CC here
L: qemu-devel@nongnu.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c
[not found] <CALvuzg6x2NjiJR=fPkgEmW2fCn6Uzy+rLAPHsC6Qn-S6hiNoqQ@mail.gmail.com>
@ 2019-01-03 17:22 ` Laurent Vivier
0 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2019-01-03 17:22 UTC (permalink / raw)
To: Jon Diekema; +Cc: qemu-trivial, David Gibson, qemu-ppc, QEMU Developers
Hi,
your patch is corrupted: please generate it with "git format-patch" and
send it with "git send-email" (you can also use git-publish)
Thanks,
Laurent
Le 25/12/2018 à 10:57, Jon Diekema a écrit :
> From b9c6caf3913487f05997144a940db0b900b17f05 Mon Sep 17 00:00:00 2001
> From: Jon Diekema <jon.diekema@ge.com <mailto:jon.diekema@ge.com>>
> Date: Tue, 25 Dec 2018 04:03:04 -0500
> Subject: Whitespace cleanup: target/ppc/translate_init.inc.c
>
> Signed-off-by: Jon Diekema <jon.diekema@ge.com <mailto:jon.diekema@ge.com>>
> ---
> target/ppc/translate_init.inc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/translate_init.inc.c
> b/target/ppc/translate_init.inc.c
> index 03f1d34a97..ac186845d0 100644
> --- a/target/ppc/translate_init.inc.c
> +++ b/target/ppc/translate_init.inc.c
> @@ -5245,7 +5245,7 @@ static void init_proc_601(CPUPPCState *env)
> 0x00000000);
> /* Memory management */
> init_excp_601(env);
> - /* XXX: beware that dcache line size is 64
> + /* XXX: beware that dcache line size is 64
> * but dcbz uses 32 bytes "sectors"
> * XXX: this breaks clcs instruction !
> */
> @@ -10493,7 +10493,7 @@ static void ppc_cpu_class_init(ObjectClass *oc,
> void *data)
> cc->tcg_initialize = ppc_translate_init;
> #endif
> cc->disas_set_info = ppc_disas_set_info;
> -
> +
> dc->fw_name = "PowerPC,UNKNOWN";
> }
>
> --
> 2.20.1.3.gf17a2b179
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-11 13:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <5c2e6965.1c69fb81.b832c.13ee@mx.google.com>
2019-01-09 10:15 ` [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c Laurent Vivier
2019-01-11 0:37 ` David Gibson
2019-01-11 7:20 ` Laurent Vivier
2019-01-11 13:05 ` Philippe Mathieu-Daudé
[not found] <CALvuzg6x2NjiJR=fPkgEmW2fCn6Uzy+rLAPHsC6Qn-S6hiNoqQ@mail.gmail.com>
2019-01-03 17:22 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.