From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 07/12] xen/events: add struct evtchn_ops for
 the low-level port operations
Date: Mon, 19 Aug 2013 11:39:00 +0100
Message-ID: <5211F5C4.3080504@citrix.com>
References: <1376072121-17786-1-git-send-email-david.vrabel@citrix.com>
	<1376072121-17786-8-git-send-email-david.vrabel@citrix.com>
	<20130816174709.GI12674@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130816174709.GI12674@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 16/08/13 18:47, Wei Liu wrote:
> On Fri, Aug 09, 2013 at 07:15:16PM +0100, David Vrabel wrote:
>> 
>> +	xen_evtchn_init_nlevel();
>> +
> 
> There is only 2-level ABI, more importantly, it is the default ABI, so
> use xen_evtchn_init_default instead?

It's not the default, FIFO is the default.  N-level is the fallback for
when the hypervisor doesn't support FIFO.

>> +
>> +static const struct evtchn_ops evtchn_ops_nlevel = {
>> +	.bind_to_cpu       = nlevel_bind_to_cpu,
>> +	.clear_pending     = nlevel_clear_pending,
>> +	.set_pending       = nlevel_set_pending,
>> +	.is_pending        = nlevel_is_pending,
>> +	.test_and_set_mask = nlevel_test_and_set_mask,
>> +	.mask              = nlevel_mask,
>> +	.unmask            = nlevel_unmask,
>> +	.handle_events     = nlevel_handle_events,
>> +};
>> +
> 
> How about use 2level_* or default_*?

Identifiers can't start with numbers.

David