Re: [PATCH 1/2] Makefile: Fix distcc compilation with x86 macros

[Nadav Amit <namit@vmware.com>]

From: Logan Gunthorpe
Sent: November 15, 2018 at 1:19:45 AM GMT
> To: Nadav Amit <namit@vmware.com>, Ingo Molnar <mingo@kernel.org>
> Cc: Ingo Molnar <mingo@redhat.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, Michal Marek <michal.lkml@markovi.net>, Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>, H. Peter Anvin <hpa@zytor.com>, X86 ML <x86@kernel.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 1/2] Makefile: Fix distcc compilation with x86 macros
> 
> 
> 
> 
> On 14/11/18 10:46 AM, Nadav Amit wrote:
>> Actually, we can just figure out whether distcc or icecc are used in the
>> Makefile according to the “version”, similarly to the way clang is detected.
>> This would neither require new Makefile arguments or Kconfig options.
>> 
>> What do you say about the following?
> 
> That may be a good idea, but I was kind of hoping to be able to add
> support for this to at least a future version of icecc (though I'm not
> committing to that...). So it would be nice to have a way to force it
> one way or the other with an environment variable.

As long as the argument was *required* to get distcc to work at all, you
could expect people would figure out an argument is needed. In this case, I
suspect nobody will ever know about this argument (except you).

Eventually, if you get a fix into icecc, we will need to change the
Makefile, consider the version number and act accordingly.

Anyhow, I’ll add an argument as you asked, and let Ingo (& others) be the
judge(s).