All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Naab <jn@stusta.de>
To: mailings@hupie.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH 2/2] net: netem: always adjust now/delay when not reordering
Date: Wed, 21 Aug 2013 17:17:06 +0200	[thread overview]
Message-ID: <5214D9F2.90900@stusta.de> (raw)
In-Reply-To: <1377011469-26151-2-git-send-email-mailings@hupie.com>

On 08/20/2013 05:11 PM, Ferry Huberts wrote:
> From: Ferry Huberts <ferry.huberts@pelagic.nl>
> 
> Not doing this (current behaviour) introduces reordering.
> 
> The packet_len_2_sched_time call is the only thing that logically
> depends on q->rate, so move the now/delay adjustment out of the if.
> 
> Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>
> ---

Hi,

The documentation for netem does explicitly mention the reordering with
jitter, and gives instructions on how to avoid it. (I have not tested if
it works as intended).

http://www.linuxfoundation.org/collaborate/workgroups/networking/netem#How_to_reorder_packets_based_on_jitter.3F

Could you test if that fixes your problem already?


Assuming that the documentation is right:

For the sake of stability I strongly oppose changing existing and
documented behavior without opt-in. (Then again I'm not involved in
kernel development.)

If the documentation turns out to be wrong:

The netem rate extension (with all the reordering changes for that case,
which are needed for proper rate emulation in that model) was introduced
in 3.3 by Hagen Paul Pfeifer
http://marc.info/?l=linux-netdev&m=132215646820338&w=2. You could ping
him, and try to get his input/Acked-by on your patch. I only did some
bug fixing in 3.8 http://marc.info/?l=linux-netdev&m=135897762224399&w=2.

Best regards,

Johannes
-- 

  parent reply	other threads:[~2013-08-21 15:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-20 15:11 [PATCH 1/2] net: netem: do not reorder when reordering is disabled Ferry Huberts
2013-08-20 15:11 ` [PATCH 2/2] net: netem: always adjust now/delay when not reordering Ferry Huberts
2013-08-20 18:31   ` Sergei Shtylyov
2013-08-20 20:33   ` Eric Dumazet
2013-08-21  5:59     ` [PATCH v2 " Ferry Huberts
2013-08-21  6:14       ` Eric Dumazet
2013-08-21  7:04         ` Ferry Huberts
2013-08-21 13:30           ` Eric Dumazet
2013-08-21 14:02             ` mailings
2013-08-21 14:10               ` mailings
2013-08-21 15:17   ` Johannes Naab [this message]
2013-08-21 15:39     ` [PATCH " Eric Dumazet
2013-08-21 16:14       ` Ferry Huberts
2013-08-21 17:00         ` Eric Dumazet
2013-08-21 17:35           ` Stephen Hemminger
2013-08-23 12:50         ` Ferry Huberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5214D9F2.90900@stusta.de \
    --to=jn@stusta.de \
    --cc=eric.dumazet@gmail.com \
    --cc=mailings@hupie.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.