From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751903AbeENBXD (ORCPT ); Sun, 13 May 2018 21:23:03 -0400 Received: from regular1.263xmail.com ([211.150.99.130]:38599 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbeENBXC (ORCPT ); Sun, 13 May 2018 21:23:02 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-IP-DOMAINF: 1 X-RL-SENDER: djw@t-chip.com.cn X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 183.57.25.242 X-LOGIN-NAME: djw@t-chip.com.cn X-UNIQUE-TAG: <190720c9aa907ec11ddbf1dbe58729fc> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v1 3/5] arm64: dts: rockchip: Add gpio-syscon10 to rk3328 To: Rob Herring Cc: "open list:ARM/Rockchip SoC..." , Wayne Chou , Heiko Stuebner , devicetree@vger.kernel.org, David Wu , Arnd Bergmann , Finley Xiao , William Wu , Sugar Zhang , "linux-kernel@vger.kernel.org" , Robin Murphy , Rocky Hao , Will Deacon , Mark Rutland , Catalin Marinas , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" References: <1525943800-14095-1-git-send-email-djw@t-chip.com.cn> <1525943800-14095-4-git-send-email-djw@t-chip.com.cn> From: Levin Du Message-ID: <5218da3c-40d3-a44f-2b82-13cd4c522a1f@t-chip.com.cn> Date: Mon, 14 May 2018 09:22:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-05-11 8:22 PM, Rob Herring wrote: > On Thu, May 10, 2018 at 4:16 AM, wrote: >> From: Levin Du >> >> Adding a new gpio controller named "gpio-syscon10" to rk3328, providing >> access to the pins defined in the syscon GRF_SOC_CON10. >> >> Boards using these special pins to control regulators or LEDs, can now >> utilize existing drivers like gpio-regulator and leds-gpio. >> >> Signed-off-by: Levin Du >> >> --- >> >> Changes in v1: >> - Split from V0 and add to rk3328.dtsi for general use. >> >> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> index b8e9da1..73a822d 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> @@ -309,6 +309,12 @@ >> mode-loader = ; >> }; >> >> + gpio_syscon10: gpio-syscon10 { > GPIO controller nodes should be named just 'gpio'. 'gpio' is a general name, and there're already gpio0~gpio3 for pinctrl GPIOs. >> + compatible = "rockchip,gpio-syscon"; >> + gpio-controller; >> + #gpio-cells = <2>; >> + gpio,syscon-dev = <0 0x0428 0>; > This property is not documented and takes a phandle. See PATCH1 which allows fetching syscon from parent node . This is also documented in Documentation/devicetree/bindings/gpio/rockchip,gpio-syscon.txt in PATCH2. Thanks Levin From mboxrd@z Thu Jan 1 00:00:00 1970 From: djw@t-chip.com.cn (Levin Du) Date: Mon, 14 May 2018 09:22:35 +0800 Subject: [PATCH v1 3/5] arm64: dts: rockchip: Add gpio-syscon10 to rk3328 In-Reply-To: References: <1525943800-14095-1-git-send-email-djw@t-chip.com.cn> <1525943800-14095-4-git-send-email-djw@t-chip.com.cn> Message-ID: <5218da3c-40d3-a44f-2b82-13cd4c522a1f@t-chip.com.cn> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2018-05-11 8:22 PM, Rob Herring wrote: > On Thu, May 10, 2018 at 4:16 AM, wrote: >> From: Levin Du >> >> Adding a new gpio controller named "gpio-syscon10" to rk3328, providing >> access to the pins defined in the syscon GRF_SOC_CON10. >> >> Boards using these special pins to control regulators or LEDs, can now >> utilize existing drivers like gpio-regulator and leds-gpio. >> >> Signed-off-by: Levin Du >> >> --- >> >> Changes in v1: >> - Split from V0 and add to rk3328.dtsi for general use. >> >> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> index b8e9da1..73a822d 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> @@ -309,6 +309,12 @@ >> mode-loader = ; >> }; >> >> + gpio_syscon10: gpio-syscon10 { > GPIO controller nodes should be named just 'gpio'. 'gpio' is a general name, and there're already gpio0~gpio3 for pinctrl GPIOs. >> + compatible = "rockchip,gpio-syscon"; >> + gpio-controller; >> + #gpio-cells = <2>; >> + gpio,syscon-dev = <0 0x0428 0>; > This property is not documented and takes a phandle. See PATCH1 which allows fetching syscon from parent node . This is also documented in Documentation/devicetree/bindings/gpio/rockchip,gpio-syscon.txt in PATCH2. Thanks Levin