From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754844Ab3H1K1M (ORCPT ); Wed, 28 Aug 2013 06:27:12 -0400 Received: from mail-bk0-f51.google.com ([209.85.214.51]:58761 "EHLO mail-bk0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752582Ab3H1K1K (ORCPT ); Wed, 28 Aug 2013 06:27:10 -0400 Message-ID: <521DD057.4040208@gmail.com> Date: Wed, 28 Aug 2013 12:26:31 +0200 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130704 Icedove/17.0.7 To: Thomas Petazzoni CC: Jean-Francois Moine , Mark Rutland , devicetree@vger.kernel.org, Russell King , Jason Cooper , Pawel Moll , Stephen Warren , linux-kernel@vger.kernel.org, Rob Herring , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, Ian Campbell Subject: Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT References: <20130828113459.48ecbb34@armhf> <521DCD33.2070008@gmail.com> <20130828121943.1c8327ca@skate> In-Reply-To: <20130828121943.1c8327ca@skate> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/28/2013 12:19 PM, Thomas Petazzoni wrote: > Sebastian, Jean-François, > > On Wed, 28 Aug 2013 12:13:07 +0200, Sebastian Hesselbarth wrote: >> On 08/28/2013 11:34 AM, Jean-Francois Moine wrote: >>> This patch adds the nodes to instantiate the audio devices of the Dove >>> boards. >>> >>> Signed-off-by: Jean-Francois Moine >>> --- >>> arch/arm/boot/dts/dove.dtsi | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi >>> index 499abad..78227e2 100644 >>> --- a/arch/arm/boot/dts/dove.dtsi >>> +++ b/arch/arm/boot/dts/dove.dtsi >>> @@ -573,6 +573,24 @@ >>> phy-handle = <ðphy>; >>> }; >>> }; >>> + >>> + i2s0: audio-controller@b0000 { >>> + compatible = "marvell,mvebu-audio"; >> >> [added Gregory to Cc] >> >> Jean-Francois, >> >> as Mark Brown already took the bindings patch for above generic >> compatible, how are we going to discriminate different >> implementations/features of Dove, Kirkwood, and Armada 370? > > I agree that mvebu-audio is not a really good compatible string. It > should use the first SoC that introduced the IP block, so that if > future SOCs have variations, we can introduce separate compatible > strings. > > So for now, the compatible string should be kirkwood-audio. Unfortunately, mvebu-audio has already been taken by Mark. Also, we know the differences for the three SoCs now and should have a compatible for each (and maybe mvebu-audio for fallback). Also, we'll need to distinguish between the different audio controllers on a single SoC, i.e. i2s0 and i2s1. I suggest checking the (phys) reg base passed. Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH 1/2] ARM: Dove: Add the audio devices in DT Date: Wed, 28 Aug 2013 12:26:31 +0200 Message-ID: <521DD057.4040208@gmail.com> References: <20130828113459.48ecbb34@armhf> <521DCD33.2070008@gmail.com> <20130828121943.1c8327ca@skate> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20130828121943.1c8327ca@skate> Sender: linux-kernel-owner@vger.kernel.org To: Thomas Petazzoni Cc: Jean-Francois Moine , Mark Rutland , devicetree@vger.kernel.org, Russell King , Jason Cooper , Pawel Moll , Stephen Warren , linux-kernel@vger.kernel.org, Rob Herring , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, Ian Campbell List-Id: devicetree@vger.kernel.org On 08/28/2013 12:19 PM, Thomas Petazzoni wrote: > Sebastian, Jean-Fran=C3=A7ois, > > On Wed, 28 Aug 2013 12:13:07 +0200, Sebastian Hesselbarth wrote: >> On 08/28/2013 11:34 AM, Jean-Francois Moine wrote: >>> This patch adds the nodes to instantiate the audio devices of the D= ove >>> boards. >>> >>> Signed-off-by: Jean-Francois Moine >>> --- >>> arch/arm/boot/dts/dove.dtsi | 18 ++++++++++++++= ++++ >>> 1 file changed, 18 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.d= tsi >>> index 499abad..78227e2 100644 >>> --- a/arch/arm/boot/dts/dove.dtsi >>> +++ b/arch/arm/boot/dts/dove.dtsi >>> @@ -573,6 +573,24 @@ >>> phy-handle =3D <ðphy>; >>> }; >>> }; >>> + >>> + i2s0: audio-controller@b0000 { >>> + compatible =3D "marvell,mvebu-audio"; >> >> [added Gregory to Cc] >> >> Jean-Francois, >> >> as Mark Brown already took the bindings patch for above generic >> compatible, how are we going to discriminate different >> implementations/features of Dove, Kirkwood, and Armada 370? > > I agree that mvebu-audio is not a really good compatible string. It > should use the first SoC that introduced the IP block, so that if > future SOCs have variations, we can introduce separate compatible > strings. > > So for now, the compatible string should be kirkwood-audio. Unfortunately, mvebu-audio has already been taken by Mark. Also, we know the differences for the three SoCs now and should have a compatibl= e for each (and maybe mvebu-audio for fallback). Also, we'll need to distinguish between the different audio controllers on a single SoC, i.e. i2s0 and i2s1. I suggest checking the (phys) reg base passed. Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth) Date: Wed, 28 Aug 2013 12:26:31 +0200 Subject: [PATCH 1/2] ARM: Dove: Add the audio devices in DT In-Reply-To: <20130828121943.1c8327ca@skate> References: <20130828113459.48ecbb34@armhf> <521DCD33.2070008@gmail.com> <20130828121943.1c8327ca@skate> Message-ID: <521DD057.4040208@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/28/2013 12:19 PM, Thomas Petazzoni wrote: > Sebastian, Jean-Fran?ois, > > On Wed, 28 Aug 2013 12:13:07 +0200, Sebastian Hesselbarth wrote: >> On 08/28/2013 11:34 AM, Jean-Francois Moine wrote: >>> This patch adds the nodes to instantiate the audio devices of the Dove >>> boards. >>> >>> Signed-off-by: Jean-Francois Moine >>> --- >>> arch/arm/boot/dts/dove.dtsi | 18 ++++++++++++++++++ >>> 1 file changed, 18 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/dove.dtsi b/arch/arm/boot/dts/dove.dtsi >>> index 499abad..78227e2 100644 >>> --- a/arch/arm/boot/dts/dove.dtsi >>> +++ b/arch/arm/boot/dts/dove.dtsi >>> @@ -573,6 +573,24 @@ >>> phy-handle = <ðphy>; >>> }; >>> }; >>> + >>> + i2s0: audio-controller at b0000 { >>> + compatible = "marvell,mvebu-audio"; >> >> [added Gregory to Cc] >> >> Jean-Francois, >> >> as Mark Brown already took the bindings patch for above generic >> compatible, how are we going to discriminate different >> implementations/features of Dove, Kirkwood, and Armada 370? > > I agree that mvebu-audio is not a really good compatible string. It > should use the first SoC that introduced the IP block, so that if > future SOCs have variations, we can introduce separate compatible > strings. > > So for now, the compatible string should be kirkwood-audio. Unfortunately, mvebu-audio has already been taken by Mark. Also, we know the differences for the three SoCs now and should have a compatible for each (and maybe mvebu-audio for fallback). Also, we'll need to distinguish between the different audio controllers on a single SoC, i.e. i2s0 and i2s1. I suggest checking the (phys) reg base passed. Sebastian