From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 168CD7F51 for ; Thu, 29 Aug 2013 07:37:43 -0500 (CDT) Message-ID: <521F4096.9040707@sgi.com> Date: Thu, 29 Aug 2013 07:37:42 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH] Re: XFS: Assertion failed: first <= last && last < BBTOB(bp->b_length), file: fs/xfs/xfs_trans_buf.c, line: 568 References: <52165830.8050006@redhat.com> <20130826041330.GU6023@dastard> In-Reply-To: <20130826041330.GU6023@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Brian Foster , xfs@oss.sgi.com On 08/25/13 23:13, Dave Chinner wrote: > xfs: fix calculation of the number of node entries in a dir3 node > > From: Dave Chinner > > The calculation doesn't take into account the size of the dir v3 > header, so overestimates the hash entries in a node. This causes > directory buffer overruns when splitting and merging nodes. > > Signed-off-by: Dave Chinner > --- Makes sense to me for the inode v3 assert. Reviewed-by: Mark Tinguely The remove assert with the same test must be in common code; it can be triggered in both versions of the inode (Linux 3.10 - TOT). The assert on the remove may require the test to be run until the filesystem is full before doing the remove. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs