From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Cc: Christoph Paasch <cpaasch@apple.com>
Subject: Re: [PATCH v6 mptcp-next 00/22] mptcp: data checksum support
Date: Wed, 05 May 2021 12:12:20 +0200 [thread overview]
Message-ID: <521bebd638f2baae1d511af64690b5c64b910d57.camel@redhat.com> (raw)
In-Reply-To: <cover.1620163861.git.pabeni@redhat.com>
On Tue, 2021-05-04 at 23:41 +0200, Paolo Abeni wrote:
> Changes from v5:
> - none really, added patch lost in previous iteration due to PEBKAC
Note: self-tests are successful here (even with -C flag), but I did not
test interoperability with mptcp.org because...
... I think mptcp.org csum implementation does not respect RFC 8684.
In the current mptcp.org git repo
@f8b7c5e4a105b9d561eb5fb8cba26efbac861bc7,
file net/mptcp/mptcp_output.c, function mptcp_write_dss_mapping():
csum = csum_partial(ptr - 2, 12, skb->csum);
p16++;
*p16++ = csum_fold(csum_partial(&hdseq, sizeof(hdseq), csum));
since the pseudo header len is 12, it looks like 4 bytes/32bits DSN is used.
But RFC 8684 section 3.3.1. says:
"""
Note that the data sequence number used in the pseudo-header is
always the 64-bit value, irrespective of what length is used in the
DSS option itself.
"""
Even RFC 6824 reports the same sentence, so it looks like I'm missing
some bits here?!?
Thanks!
Paolo
next prev parent reply other threads:[~2021-05-05 10:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 21:41 [PATCH v6 mptcp-next 00/22] mptcp: data checksum support Paolo Abeni
2021-05-04 21:41 ` [PATCH v6 mptcp-next 01/22] mptcp: add csum_enabled in mptcp_sock Paolo Abeni
2021-05-04 21:41 ` [PATCH v6 mptcp-next 02/22] mptcp: generate the data checksum Paolo Abeni
2021-05-04 21:41 ` [PATCH v6 mptcp-next 03/22] Squash-to: "mptcp: generate the data checksum" Paolo Abeni
2021-05-04 21:41 ` [PATCH v6 mptcp-next 04/22] mptcp: add csum_reqd in mptcp_out_options Paolo Abeni
2021-05-04 21:41 ` [PATCH v6 mptcp-next 05/22] mptcp: send out checksum for MP_CAPABLE with data Paolo Abeni
2021-05-04 21:41 ` [PATCH v6 mptcp-next 06/22] Squash-to: "mptcp: send out checksum for MP_CAPABLE with data" Paolo Abeni
2021-05-04 21:41 ` [PATCH v6 mptcp-next 07/22] mptcp: send out checksum for DSS Paolo Abeni
2021-05-04 21:41 ` [PATCH v6 mptcp-next 08/22] Squash-to "mptcp: send out checksum for DSS" Paolo Abeni
2021-05-04 21:41 ` [PATCH v6 mptcp-next 09/22] mptcp: add sk parameter for mptcp_parse_option Paolo Abeni
2021-05-04 21:41 ` [PATCH v6 mptcp-next 10/22] mptcp: add csum_reqd in mptcp_options_received Paolo Abeni
2021-05-04 21:41 ` [PATCH v6 mptcp-next 11/22] mptcp: receive checksum for MP_CAPABLE with data Paolo Abeni
2021-05-04 21:42 ` [PATCH v6 mptcp-next 12/22] Squash-to: "mptcp: receive checksum for MP_CAPABLE with data" Paolo Abeni
2021-05-04 21:42 ` [PATCH v6 mptcp-next 13/22] mptcp: receive checksum for DSS Paolo Abeni
2021-05-04 21:42 ` [PATCH v6 mptcp-next 14/22] Squash-to: "mptcp: receive checksum for DSS" Paolo Abeni
2021-05-04 21:42 ` [PATCH v6 mptcp-next 15/22] mptcp: validate the data checksum Paolo Abeni
2021-05-04 21:42 ` [PATCH v6 mptcp-next 16/22] Squash-to: " Paolo Abeni
2021-05-04 21:42 ` [PATCH v6 mptcp-next 17/22] mptcp: cleanup error path in subflow_check_data_avail() Paolo Abeni
2021-05-04 21:42 ` [PATCH v6 mptcp-next 18/22] mptcp: tune re-injections for csum enabled mode Paolo Abeni
2021-05-04 21:42 ` [PATCH v6 mptcp-next 19/22] mptcp: add the mib for data checksum Paolo Abeni
2021-05-04 21:42 ` [PATCH v6 mptcp-next 20/22] mptcp: add a new sysctl checksum_enabled Paolo Abeni
2021-05-04 21:42 ` [PATCH v6 mptcp-next 21/22] selftests: mptcp: enable checksum in mptcp_connect.sh Paolo Abeni
2021-05-04 21:42 ` [PATCH v6 mptcp-next 22/22] selftests: mptcp: enable checksum in mptcp_join.sh Paolo Abeni
2021-05-05 10:12 ` Paolo Abeni [this message]
2021-05-05 18:03 ` [PATCH v6 mptcp-next 00/22] mptcp: data checksum support Mat Martineau
2021-05-05 23:56 ` Mat Martineau
2021-05-06 8:31 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521bebd638f2baae1d511af64690b5c64b910d57.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=cpaasch@apple.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.