All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Durgin <josh.durgin@inktank.com>
To: Wido den Hollander <wido@42on.com>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: libvirt: Using rbd_create3 to create format 2 images
Date: Fri, 30 Aug 2013 08:26:00 -0700	[thread overview]
Message-ID: <5220B988.9060906@inktank.com> (raw)
In-Reply-To: <5220691A.1080604@42on.com>

On 08/30/2013 02:42 AM, Wido den Hollander wrote:
> Hi,
>
> I created the attached patch to have libvirt create images with format 2
> by default, this would simplify the CloudStack code and could also help
> other projects.
>
> The problem with libvirt is that there is no mechanism to supply
> information like order, features, stripe unit and count to the
> rbd_create3 method, so it's now hardcoded in libvirt.
>
> Any comments on this patch before I fire it of to the libvirt guys?

Seems ok to me. They might want you to detect whether the function is
there and compile without it if librbd doesn't support it (rbd_create3
first appeared in bobtail).


  reply	other threads:[~2013-08-30 15:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  9:42 libvirt: Using rbd_create3 to create format 2 images Wido den Hollander
2013-08-30 15:26 ` Josh Durgin [this message]
2013-08-30 18:38   ` Wido den Hollander
2013-09-02 14:58     ` Wido den Hollander
2013-09-03 18:23       ` Josh Durgin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5220B988.9060906@inktank.com \
    --to=josh.durgin@inktank.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=wido@42on.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.