From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFS9P-0005kN-IW for qemu-devel@nongnu.org; Fri, 30 Aug 2013 13:06:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFS9H-0001xs-G7 for qemu-devel@nongnu.org; Fri, 30 Aug 2013 13:06:23 -0400 Message-ID: <5220D0F6.3010401@reactos.org> Date: Fri, 30 Aug 2013 19:05:58 +0200 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1376390314-17544-1-git-send-email-hpoussin@reactos.org> <5220BE16.6090103@redhat.com> <5220C0B7.4030108@suse.de> In-Reply-To: <5220C0B7.4030108@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-trivial@nongnu.org, Paolo Bonzini , qemu-devel@nongnu.org Andreas F=C3=A4rber a =C3=A9crit : > Am 30.08.2013 17:45, schrieb Paolo Bonzini: >> Il 13/08/2013 12:38, Herv=C3=A9 Poussineau ha scritto: >>> Signed-off-by: Herv=C3=A9 Poussineau >>> --- >>> include/hw/isa/isa.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h >>> index 495bcf3..fa45a5b 100644 >>> --- a/include/hw/isa/isa.h >>> +++ b/include/hw/isa/isa.h >>> @@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryRegi= on *io, uint16_t start); >>> * @dev: the ISADevice against which these are registered; may be NU= LL. >>> * @start: the base I/O port against which the portio->offset is app= lied. >>> * @portio: the ports, sorted by offset. >>> - * @opaque: passed into the old_portio callbacks. >>> + * @opaque: passed into the portio callbacks. >>> * @name: passed into memory_region_init_io. >>> */ >>> void isa_register_portio_list(ISADevice *dev, uint16_t start, >>> >> Ping. >=20 > If you actually give it a Reviewed-by I can take it through qom-next. >=20 > Commit message does not point to a commit X for trivial verification > that it is in fact correct since X. Just above the changed line, the ports variable is named "portio", not=20 "old_portio". Herv=C3=A9