From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFSRW-0006Bm-2o for qemu-devel@nongnu.org; Fri, 30 Aug 2013 13:25:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFSRQ-0008Ip-Su for qemu-devel@nongnu.org; Fri, 30 Aug 2013 13:25:06 -0400 Message-ID: <5220D568.8080103@suse.de> Date: Fri, 30 Aug 2013 19:24:56 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1376390314-17544-1-git-send-email-hpoussin@reactos.org> <5220BE16.6090103@redhat.com> <5220C0B7.4030108@suse.de> <5220C226.1080905@redhat.com> In-Reply-To: <5220C226.1080905@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] PING Re: [PATCH for-1.6] isa: fix documentation of isa_register_portio_list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Am 30.08.2013 18:02, schrieb Paolo Bonzini: > Il 30/08/2013 17:56, Andreas F=C3=A4rber ha scritto: >> Am 30.08.2013 17:45, schrieb Paolo Bonzini: >>> Il 13/08/2013 12:38, Herv=C3=A9 Poussineau ha scritto: >>>> >>>> Signed-off-by: Herv=C3=A9 Poussineau >>>> --- >>>> include/hw/isa/isa.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h >>>> index 495bcf3..fa45a5b 100644 >>>> --- a/include/hw/isa/isa.h >>>> +++ b/include/hw/isa/isa.h >>>> @@ -78,7 +78,7 @@ void isa_register_ioport(ISADevice *dev, MemoryReg= ion *io, uint16_t start); >>>> * @dev: the ISADevice against which these are registered; may be N= ULL. >>>> * @start: the base I/O port against which the portio->offset is ap= plied. >>>> * @portio: the ports, sorted by offset. >>>> - * @opaque: passed into the old_portio callbacks. >>>> + * @opaque: passed into the portio callbacks. >>>> * @name: passed into memory_region_init_io. >>>> */ >>>> void isa_register_portio_list(ISADevice *dev, uint16_t start, >>>> >>> >>> Ping. >> >> If you actually give it a Reviewed-by I can take it through qom-next. >> >> Commit message does not point to a commit X for trivial verification >> that it is in fact correct since X. >=20 > Commit b40acf9 (ioport: Switch dispatching to memory core layer, > 2013-06-24) removed all instances of old_portio Thanks, I've copied it into the commit message and consider this an Acked-by. Applied to qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next Andreas > except this, one in > docs/memory.txt, and one in hw/ppc/spapr_pci.c. >=20 > Paolo >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg