From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wido den Hollander Subject: Re: libvirt: Using rbd_create3 to create format 2 images Date: Fri, 30 Aug 2013 20:38:46 +0200 Message-ID: <5220E6B6.7030008@42on.com> References: <5220691A.1080604@42on.com> <5220B988.9060906@inktank.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from websrv.42on.com ([31.25.102.167]:58403 "EHLO websrv.42on.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753131Ab3H3Sis (ORCPT ); Fri, 30 Aug 2013 14:38:48 -0400 In-Reply-To: <5220B988.9060906@inktank.com> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Josh Durgin Cc: "ceph-devel@vger.kernel.org" On 08/30/2013 05:26 PM, Josh Durgin wrote: > On 08/30/2013 02:42 AM, Wido den Hollander wrote: >> Hi, >> >> I created the attached patch to have libvirt create images with format 2 >> by default, this would simplify the CloudStack code and could also help >> other projects. >> >> The problem with libvirt is that there is no mechanism to supply >> information like order, features, stripe unit and count to the >> rbd_create3 method, so it's now hardcoded in libvirt. >> >> Any comments on this patch before I fire it of to the libvirt guys? > > Seems ok to me. They might want you to detect whether the function is > there and compile without it if librbd doesn't support it (rbd_create3 > first appeared in bobtail). > Good one. Although I don't think anybody is still running Argonaut I'll do a version check of librbd and switch to rbd_create if needed. -- Wido den Hollander 42on B.V. Phone: +31 (0)20 700 9902 Skype: contact42on