From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGvOC-0002On-0b for qemu-devel@nongnu.org; Tue, 03 Sep 2013 14:31:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGvO2-0003YW-1R for qemu-devel@nongnu.org; Tue, 03 Sep 2013 14:31:42 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:39642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGvO1-0003YS-S7 for qemu-devel@nongnu.org; Tue, 03 Sep 2013 14:31:33 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Sep 2013 19:31:32 +0100 Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id AC7EBC900A6 for ; Tue, 3 Sep 2013 14:31:16 -0400 (EDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by b01cxnp23034.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r83ICv3P16711858 for ; Tue, 3 Sep 2013 18:31:16 GMT Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r83IBPS5009295 for ; Tue, 3 Sep 2013 12:11:25 -0600 Message-ID: <5226259C.30400@linux.vnet.ibm.com> Date: Tue, 03 Sep 2013 14:08:28 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1377738272-3470-1-git-send-email-otubo@linux.vnet.ibm.com> <20130829083411.GD23096@stefanha-thinkpad.redhat.com> <5220AA75.7080402@linux.vnet.ibm.com> <5226243B.6040001@linux.vnet.ibm.com> In-Reply-To: <5226243B.6040001@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] seccomp: adding a second whitelist List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Otubo Cc: pmoore@redhat.com, Stefan Hajnoczi , wad@chromium.org, qemu-devel@nongnu.org On 09/03/2013 02:02 PM, Corey Bryant wrote: > > > On 08/30/2013 10:21 AM, Eduardo Otubo wrote: >> >> >> On 08/29/2013 05:34 AM, Stefan Hajnoczi wrote: >>> On Wed, Aug 28, 2013 at 10:04:32PM -0300, Eduardo Otubo wrote: >>>> Now there's a second whitelist, right before the vcpu starts. The >>>> second >>>> whitelist is the same as the first one, except for exec() and select(). >>> >>> -netdev tap,downscript=/path/to/script requires exec() in the QEMU >>> shutdown code path. Will this work with seccomp? >> >> I actually don't know, but I'll test that as well. Can you run a test >> with this patch and -netdev? I mean, if you're pointing that out you >> might have a scenario already setup, right? >> >> Thanks! >> > > This uses exec() in net/tap.c. > > I think if we're going to introduce a sandbox environment that restricts > existing QEMU behavior, then we have to introduce a new argument to the > -sandbox option. So for example, "-sandbox on" would continue to use > the whitelist that allows everything in QEMU to work (or at least it > should :). And something like "-sandbox on,strict=on" would use the > whitelist + blacklist. > > If this is acceptable though, then I wonder how we could go about adding > new syscalls to the blacklist in future QEMU releases without regressing > "-sandbox on,strict=on". Maybe a better approach is to provide support that allows libvirt to define the blacklist and pass it to QEMU? > > By the way, are any test buckets running regularly with -sandbox on? > -- Regards, Corey Bryant