From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eelco Chaudron" Subject: Re: [PATCH iproute2/net-next v2] tc_util: Add support for showing TCA_STATS_BASIC_HW statistics Date: Fri, 10 Aug 2018 16:48:42 +0200 Message-ID: <52262814-6824-44EF-B10C-C7AD96A0FA57@redhat.com> References: <20180810115846.15762.3693.stgit@wsfd-netdev20.ntdv.lab.eng.bos.redhat.com> <20180810074454.4af9e5cd@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, davem@davemloft.net To: "Stephen Hemminger" Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42874 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727477AbeHJRS5 (ORCPT ); Fri, 10 Aug 2018 13:18:57 -0400 In-Reply-To: <20180810074454.4af9e5cd@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: On 10 Aug 2018, at 16:44, Stephen Hemminger wrote: > On Fri, 10 Aug 2018 07:59:30 -0400 > Eelco Chaudron wrote: > >> + if (bs.bytes >= bs_hw.bytes && bs.packets >= bs_hw.packets) { >> + print_string(PRINT_FP, NULL, "%s", _SL_); >> + print_string(PRINT_FP, NULL, "%s", prefix); >> + print_lluint(PRINT_ANY, "sw_bytes", >> + "Sent software %llu bytes", >> + bs.bytes - bs_hw.bytes); >> + print_uint(PRINT_ANY, "sw_packets", " %u pkt", >> + bs.packets - bs_hw.packets); >> + } >> + } >> + >> + print_string(PRINT_FP, NULL, "%s", _SL_); >> + print_string(PRINT_FP, NULL, "%s", prefix); >> + print_lluint(PRINT_ANY, "hw_bytes", "Sent hardware %llu bytes", >> + bs_hw.bytes); > > What does the output look like? See the two +’es below: $ tc -s filter show dev enp3s0np0 parent ffff: filter protocol ip pref 1 flower chain 0 filter protocol ip pref 1 flower chain 0 handle 0x1 eth_type ipv4 dst_ip 2.0.0.0 src_ip 1.0.0.0 ip_flags nofrag in_hw action order 1: mirred (Egress Redirect to device eth1) stolen index 1 ref 1 bind 1 installed 0 sec used 0 sec Action statistics: Sent 534884742 bytes 8915697 pkt (dropped 0, overlimits 0 requeues 0) + Sent software 187542 bytes 4077 pkt + Sent hardware 534697200 bytes 8911620 pkt backlog 0b 0p requeues 0 cookie 89173e6a44447001becfd486bda17e29