All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valentijn Sessink <valentyn@blub.net>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: xt_recent.c bug - and cleanup
Date: Thu, 05 Sep 2013 16:55:17 +0200	[thread overview]
Message-ID: <52289B55.1000902@blub.net> (raw)
In-Reply-To: <20130830152448.GB7648@linuxace.com>

Hi Phil,

On 30-08-13 17:24, Phil Oester wrote:
> Eh?  You might be misreading the code.

I was. I stand corrected.
[...]

> You can certainly use inversion with this match, but in your original example,
> you are expecting that anything which does not match will get it's timestamp
> updated.  That is simply not how the match works.

I contacted Stephen Frost to ask his opinion about the "!" qualifier and 
he agrees with the current source, i.e. only update if the match returns 
true.

Thank you for your thorough reading and sorry for the misunderstanding. 
I have closed the bug.

Best regards,

Valentijn Sessink




      reply	other threads:[~2013-09-05 14:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-29 10:16 xt_recent.c bug - and cleanup Valentijn Sessink
2013-08-29 22:09 ` Phil Oester
2013-08-30  5:27   ` Valentijn Sessink
2013-08-30 15:24     ` Phil Oester
2013-09-05 14:55       ` Valentijn Sessink [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52289B55.1000902@blub.net \
    --to=valentyn@blub.net \
    --cc=kernel@linuxace.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.