From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v2] xen/console: buffer and show origin of guest PV writes Date: Mon, 09 Sep 2013 13:48:32 +0100 Message-ID: <522DDFC002000078000F17D2@nat28.tlf.novell.com> References: <1376679706-2896-1-git-send-email-dgdegra@tycho.nsa.gov> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Keir Fraser , Daniel De Graaf Cc: Andrew Cooper , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org >>> On 09.09.13 at 13:13, Keir Fraser wrote: > On 16/08/2013 20:01, "Daniel De Graaf" wrote: > >> Guests other than domain 0 using the console output have previously been >> controlled by the VERBOSE define, but with no designation of which >> guest's output was on the console. This patch converts the HVM output >> buffering to be used by all domains, line buffering their output and >> prefixing it with the domain ID. This is especially useful for debugging >> stub domains. >> >> Signed-off-by: Daniel De Graaf > > This seems good, but, if we process and buffer dom0's output, we lose the > possibility of running a terminal session in dom0 over the Xen console. > Personally I do that quite a bit -- serial access only, get Xen's debugging > there, but also can log in to dom0. Does noone else?? I use this only rarely; where possible I prefer using the normal (VGA) console, and in most other cases ssh access to a remote machine is available. But yes, I view this as an important feature too, and simply failed to realize it would get broken by the change here. Jan