All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Lior Amsalem <alior@marvell.com>,
	Tawfik Bayouk <tawfik@marvell.com>,
	haojian.zhuang@gmail.com, b32955@freescale.com,
	linux-mtd@lists.infradead.org,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Brian Norris <computersforpeace@gmail.com>,
	Willy Tarreau <w@1wt.eu>
Subject: Re: [RFC/PATCH v2] mtd: nand: pxa3xx: Remove redundant device probing
Date: Tue, 10 Sep 2013 16:14:25 +0200	[thread overview]
Message-ID: <522F2941.4030406@gmail.com> (raw)
In-Reply-To: <20130910135729.GA32715@localhost>

On 10.09.2013 15:57, Ezequiel Garcia wrote:
> On Tue, Sep 10, 2013 at 03:46:49PM +0200, Daniel Mack wrote:

>> Apart from that, this seems to work fine on my board,
> 
> Great! Which board is that?

It's a custom board featuring a PXA303 processor connected to a ST Micro
NAND:

[    2.655607] NAND device: Manufacturer ID: 0x20, Chip ID: 0xa1 (ST
Micro NAND01GR3B2CZA6), 128MiB, page size: 2048, OOB size: 64

>> but I suspect that
>> it would break systems where the NAND controller is not initialized from
>> the bootloader, right?
>>
> 
> Right. However, since we can easily add support to configure every controller
> parameter (right?) this shouldn't be a problem.
> 
> What do you think of this change, Daniel?

I always thought that this detail of the pxa nand driver is ugly :) But
I'd say before it can be merged, you need to provide code to set the
timing from parameters obtained from generic part. Are you working on
this? I'd happily test more patches.

> IMO, the code is ugly, useless and deprecated enough to consider its removal.
> It forces to keep a (duplicated) list of known flash devices and it considers
> only 512 and 2048 page sizes, just to name a few limitations.

Jup, agreed.


Thanks,
Daniel

  reply	other threads:[~2013-09-10 14:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-10 11:17 [RFC/PATCH v2] pxa3xx-nand: Remove custom device detection Ezequiel Garcia
2013-09-10 11:17 ` [RFC/PATCH v2] mtd: nand: pxa3xx: Remove redundant device probing Ezequiel Garcia
2013-09-10 13:46   ` Daniel Mack
2013-09-10 13:57     ` Ezequiel Garcia
2013-09-10 14:14       ` Daniel Mack [this message]
2013-09-10 14:21         ` Ezequiel Garcia
2013-09-24 21:46         ` Setting NAND timings parameters (Re: [RFC/PATCH v2] mtd: nand: pxa3xx: Remove redundant device probing) Ezequiel Garcia
2013-11-26 23:17           ` Brian Norris
2013-11-27 11:38             ` Ezequiel Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=522F2941.4030406@gmail.com \
    --to=zonque@gmail.com \
    --cc=alior@marvell.com \
    --cc=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=tawfik@marvell.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.