From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965614AbcJYKab (ORCPT ); Tue, 25 Oct 2016 06:30:31 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:48043 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933652AbcJYKa1 (ORCPT ); Tue, 25 Oct 2016 06:30:27 -0400 Subject: Re: [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for ohci plat boot To: , , , , , , , , , , References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-9-ahaslam@baylibre.com> CC: , , , From: Sekhar Nori Message-ID: <522eeb9a-6fb1-88eb-5c58-7ee209a50fc3@ti.com> Date: Tue, 25 Oct 2016 15:58:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161024164634.4330-9-ahaslam@baylibre.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 24 October 2016 10:16 PM, ahaslam@baylibre.com wrote: > From: Axel Haslam > > The phy framework requests an optional "phy" regulator. If it does > not find one, it returns -EPROBE_DEFER. In the case of non-DT based boot > for the omap138-lcdk board, this would prevent the usb11 phy to probe > correctly and ohci would not enumerate. > > By calling "regulator_has_full_constraints", An error would be returned nit: prefer regulator_has_full_constraints() > instead of DEFER for the "optional" regulator, and the probe of > the phy driver can continue normally without a regulator. > > Signed-off-by: Axel Haslam Looks good to me. Just drop the "hawk: from subject line since you also touch da830 evm. I am not sure what "ohci plat boot" means. How about the following: "ARM: davinci: da8xx: fix OHCI PHY probe for non-DT boot" Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for ohci plat boot Date: Tue, 25 Oct 2016 15:58:53 +0530 Message-ID: <522eeb9a-6fb1-88eb-5c58-7ee209a50fc3@ti.com> References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-9-ahaslam@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161024164634.4330-9-ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, sshtylyov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org, david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org, manjunath.goudar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Monday 24 October 2016 10:16 PM, ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org wrote: > From: Axel Haslam > > The phy framework requests an optional "phy" regulator. If it does > not find one, it returns -EPROBE_DEFER. In the case of non-DT based boot > for the omap138-lcdk board, this would prevent the usb11 phy to probe > correctly and ohci would not enumerate. > > By calling "regulator_has_full_constraints", An error would be returned nit: prefer regulator_has_full_constraints() > instead of DEFER for the "optional" regulator, and the probe of > the phy driver can continue normally without a regulator. > > Signed-off-by: Axel Haslam Looks good to me. Just drop the "hawk: from subject line since you also touch da830 evm. I am not sure what "ohci plat boot" means. How about the following: "ARM: davinci: da8xx: fix OHCI PHY probe for non-DT boot" Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Tue, 25 Oct 2016 15:58:53 +0530 Subject: [PATCH/RFT v2 08/17] ARM: davinci: hawk: add full constraints for ohci plat boot In-Reply-To: <20161024164634.4330-9-ahaslam@baylibre.com> References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-9-ahaslam@baylibre.com> Message-ID: <522eeb9a-6fb1-88eb-5c58-7ee209a50fc3@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 24 October 2016 10:16 PM, ahaslam at baylibre.com wrote: > From: Axel Haslam > > The phy framework requests an optional "phy" regulator. If it does > not find one, it returns -EPROBE_DEFER. In the case of non-DT based boot > for the omap138-lcdk board, this would prevent the usb11 phy to probe > correctly and ohci would not enumerate. > > By calling "regulator_has_full_constraints", An error would be returned nit: prefer regulator_has_full_constraints() > instead of DEFER for the "optional" regulator, and the probe of > the phy driver can continue normally without a regulator. > > Signed-off-by: Axel Haslam Looks good to me. Just drop the "hawk: from subject line since you also touch da830 evm. I am not sure what "ohci plat boot" means. How about the following: "ARM: davinci: da8xx: fix OHCI PHY probe for non-DT boot" Thanks, Sekhar