From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FDBEC47083 for ; Wed, 2 Jun 2021 21:46:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42059613E7 for ; Wed, 2 Jun 2021 21:46:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229576AbhFBVs2 (ORCPT ); Wed, 2 Jun 2021 17:48:28 -0400 Received: from mail-lf1-f42.google.com ([209.85.167.42]:33540 "EHLO mail-lf1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbhFBVs1 (ORCPT ); Wed, 2 Jun 2021 17:48:27 -0400 Received: by mail-lf1-f42.google.com with SMTP id a5so5657294lfm.0 for ; Wed, 02 Jun 2021 14:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7sNxat3i9/RN2yykF6irefH0yK7Y1BVv/cXFGY3PCQ8=; b=gYX6BAVAoigjrGq4AHuBLFG+Ap19bznrpH06DcwQhRwrJBBkgUMuXX1w5XHhSw2YOg LuqytIGNmUaCWMbVWwOJ/vVGWk3OvFfaUtw7y5GMsm0CUUMB60UUBUo4qQLZv2m3k0jn nzlFjimGVmJWwhHMseLNRYBWZQiOP8glwmjUZkpvjOhjC95dArdz9kfndDfkOkPPHTP0 jkF9AdtNuu5ZH1zKg+9JyWbr4n/0bYL2qmY2X+W96yZ8SGSeSJKEsNMGgP3BqdeIFi9N Cxh/rV36CmCv2C4xP8YXO+yjeYrF0gOFE5YOkNZhiKM+wkiZGLXloSIWAKqITk3SRq2E aCuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7sNxat3i9/RN2yykF6irefH0yK7Y1BVv/cXFGY3PCQ8=; b=IuXq8g5eGOMGjrP/6X0n2fQ83tcYydEOCFoGFzz7rhLU8J+ae7+H3pL4dxSZIkxE3Z z/F5axN0CT6XFinz65Mfs/gi3Z2tgstWyato0uiij6fa4w43h03byxsjfedOJk6XnLHX oZZSNmURD5XQrK+TNQbAsPK7xSuwc0pQYKProagpnCzVaJYdRbXhLaFVF4Cl10jh95Wc DiEOep9qMYh7UAgjqgt7bKov5st/g1VggUiAwNtUyCTQ+0S1aIbfqULTFIp3iIurkJrX hxGGJwGL8in2lqkDAUw4BCEyjtLjD7ljqW6LexDgT2eppfcJRGbW89Ve4+r5VfTOCUHY jspg== X-Gm-Message-State: AOAM531VH9XjNDEM1gf+U6yCBwl/9TEqsdHCRE5sFsY84s9ohNnEpw/q bnE0nLy76tfcrc679jUELbdVhQ== X-Google-Smtp-Source: ABdhPJyLab5zzBNyzPzXm77Co4XUVWe+ObknhW7ybl82GSpdoxVmftuwnJLvpsRiaVkEX81lTkNUAA== X-Received: by 2002:ac2:4f8b:: with SMTP id z11mr23206848lfs.482.1622670343227; Wed, 02 Jun 2021 14:45:43 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id m19sm108033lfb.121.2021.06.02.14.45.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 14:45:42 -0700 (PDT) Subject: Re: From: Dmitry Baryshkov To: Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar Cc: Jonathan Marek , Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20210515225757.1989955-1-dmitry.baryshkov@linaro.org> Message-ID: <52307126-b252-f6d1-3a38-a6a262b2fed2@linaro.org> Date: Thu, 3 Jun 2021 00:45:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210515225757.1989955-1-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 16/05/2021 01:57, Dmitry Baryshkov wrote: > From Dmitry Baryshkov # This line is ignored. > From: Dmitry Baryshkov > Reply-To: > Subject: [PATCH v2 0/6] drm/msm/dpu: simplify RM code > In-Reply-To: > > There is no need to request most of hardware blocks through the resource > manager (RM), since typically there is 1:1 or N:1 relationship between > corresponding blocks. Each LM is tied to the single PP. Each MERGE_3D > can be used by the specified pair of PPs. Each DSPP is also tied to > single LM. So instead of allocating them through the RM, get them via > static configuration. > > Depends on: https://lore.kernel.org/linux-arm-msm/20210515190909.1809050-1-dmitry.baryshkov@linaro.org > > Changes since v1: > - Split into separate patch series to ease review. Another gracious ping, now for this series. I want to send next version with minor changes, but I'd like to hear your overall opinion before doing that. > > ---------------------------------------------------------------- > Dmitry Baryshkov (6): > drm/msm/dpu: get DSPP blocks directly rather than through RM > drm/msm/dpu: get MERGE_3D blocks directly rather than through RM > drm/msm/dpu: get PINGPONG blocks directly rather than through RM > drm/msm/dpu: get INTF blocks directly rather than through RM > drm/msm/dpu: drop unused lm_max_width from RM > drm/msm/dpu: simplify peer LM handling > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 54 +--- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 8 - > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 5 - > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 8 - > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 - > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 14 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 7 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 7 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 4 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 53 +++- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 5 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 310 ++------------------- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 18 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 9 +- > 16 files changed, 115 insertions(+), 401 deletions(-) > > -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C733C47083 for ; Wed, 2 Jun 2021 21:45:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20DC0613E7 for ; Wed, 2 Jun 2021 21:45:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20DC0613E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 90E666EC76; Wed, 2 Jun 2021 21:45:46 +0000 (UTC) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by gabe.freedesktop.org (Postfix) with ESMTPS id A89526EC76 for ; Wed, 2 Jun 2021 21:45:44 +0000 (UTC) Received: by mail-lf1-x130.google.com with SMTP id x38so5592121lfa.10 for ; Wed, 02 Jun 2021 14:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7sNxat3i9/RN2yykF6irefH0yK7Y1BVv/cXFGY3PCQ8=; b=gYX6BAVAoigjrGq4AHuBLFG+Ap19bznrpH06DcwQhRwrJBBkgUMuXX1w5XHhSw2YOg LuqytIGNmUaCWMbVWwOJ/vVGWk3OvFfaUtw7y5GMsm0CUUMB60UUBUo4qQLZv2m3k0jn nzlFjimGVmJWwhHMseLNRYBWZQiOP8glwmjUZkpvjOhjC95dArdz9kfndDfkOkPPHTP0 jkF9AdtNuu5ZH1zKg+9JyWbr4n/0bYL2qmY2X+W96yZ8SGSeSJKEsNMGgP3BqdeIFi9N Cxh/rV36CmCv2C4xP8YXO+yjeYrF0gOFE5YOkNZhiKM+wkiZGLXloSIWAKqITk3SRq2E aCuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7sNxat3i9/RN2yykF6irefH0yK7Y1BVv/cXFGY3PCQ8=; b=M45p7jXrZnwSywJzi8ecYp6b6wVvEAHfbTe78HmEHHissK6nGwLr4nrekUV+rjmsW0 Dvogbxd3WPj3sfD1h2vbPpIbvur1sa5tTpIZCZYtuevlxTxopXLFxR+oLI+/DINqDSbg lCYa/p+WYxYnAHO5TYW5TSE7LTWEv7WVY4CqY5p1HROjpcXGcz5rFHJOIwqzxhFK60Hk rw/xW36lzc7FYrXrqkvFdQUzFyfEs+t33HrJn2fpeDY/G9EAspsr8qPUJiONZJZ0L2XD D1UdNB+/rKGCjj5agAF8K5eecKt+8WnRhYodk9BSjSGoOp6GL58XDGiovBsaxv727CP0 vTeA== X-Gm-Message-State: AOAM533ywd+1MsnuzzOKUtFImI5lSE4l9f4vWVIwHRUh3YGGsrcvK72E DhNQ0c/XhX525u4tNXZr4r7M7g== X-Google-Smtp-Source: ABdhPJyLab5zzBNyzPzXm77Co4XUVWe+ObknhW7ybl82GSpdoxVmftuwnJLvpsRiaVkEX81lTkNUAA== X-Received: by 2002:ac2:4f8b:: with SMTP id z11mr23206848lfs.482.1622670343227; Wed, 02 Jun 2021 14:45:43 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id m19sm108033lfb.121.2021.06.02.14.45.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 14:45:42 -0700 (PDT) Subject: Re: From: Dmitry Baryshkov To: Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar References: <20210515225757.1989955-1-dmitry.baryshkov@linaro.org> Message-ID: <52307126-b252-f6d1-3a38-a6a262b2fed2@linaro.org> Date: Thu, 3 Jun 2021 00:45:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210515225757.1989955-1-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Marek , Stephen Boyd , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 16/05/2021 01:57, Dmitry Baryshkov wrote: > From Dmitry Baryshkov # This line is ignored. > From: Dmitry Baryshkov > Reply-To: > Subject: [PATCH v2 0/6] drm/msm/dpu: simplify RM code > In-Reply-To: > > There is no need to request most of hardware blocks through the resource > manager (RM), since typically there is 1:1 or N:1 relationship between > corresponding blocks. Each LM is tied to the single PP. Each MERGE_3D > can be used by the specified pair of PPs. Each DSPP is also tied to > single LM. So instead of allocating them through the RM, get them via > static configuration. > > Depends on: https://lore.kernel.org/linux-arm-msm/20210515190909.1809050-1-dmitry.baryshkov@linaro.org > > Changes since v1: > - Split into separate patch series to ease review. Another gracious ping, now for this series. I want to send next version with minor changes, but I'd like to hear your overall opinion before doing that. > > ---------------------------------------------------------------- > Dmitry Baryshkov (6): > drm/msm/dpu: get DSPP blocks directly rather than through RM > drm/msm/dpu: get MERGE_3D blocks directly rather than through RM > drm/msm/dpu: get PINGPONG blocks directly rather than through RM > drm/msm/dpu: get INTF blocks directly rather than through RM > drm/msm/dpu: drop unused lm_max_width from RM > drm/msm/dpu: simplify peer LM handling > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 54 +--- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 8 - > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 5 - > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 8 - > .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 - > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 14 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 7 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 7 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 4 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 53 +++- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 5 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 310 ++------------------- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 18 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 9 +- > 16 files changed, 115 insertions(+), 401 deletions(-) > > -- With best wishes Dmitry