From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5688DC433EF for ; Mon, 20 Sep 2021 16:38:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00A88611AE for ; Mon, 20 Sep 2021 16:38:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 00A88611AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:55226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSMJU-0005vu-5J for qemu-devel@archiver.kernel.org; Mon, 20 Sep 2021 12:38:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSM5b-00076Y-6R for qemu-devel@nongnu.org; Mon, 20 Sep 2021 12:24:20 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:44824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSM5Y-0004zX-QQ for qemu-devel@nongnu.org; Mon, 20 Sep 2021 12:24:18 -0400 Received: by mail-pj1-x1032.google.com with SMTP id nn5-20020a17090b38c500b0019af1c4b31fso350182pjb.3 for ; Mon, 20 Sep 2021 09:24:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=OSXVE+16/LCzF20cu4GeV88BfUZ8DskqLZEgZQN89UY=; b=tAK0wuZme9MLdNCcHsC0NLb3gVbwgAbjVJ/YSwdDxVxLYEOSJHqc7taBh1rYr1wnsI csAxTwgxnSiOtkYMOCXEnS6K0HWG+wzBbMPSaQHHmMYwP+Xv2zrg+H/7uaP0kmPS4Ltz oN405b0RN5zJbABlFX1YPcuvuQ6GaBILVBYHduxkF/0nJ2+sLNY9zcbLLmCccmUkri5V aUm3YS4nWJvmaoRn2kAayjV8LBN0BWJgJtqQp2UCq5AJAe/L39ZxX/kaSpfPk4hgOi0u cfb+FG4ZPO7zcvMIx06LTairT1Tw4gSyTfNaJjjTFTCDDexPrXgEUvwXykFH2sa0yNBz EP0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OSXVE+16/LCzF20cu4GeV88BfUZ8DskqLZEgZQN89UY=; b=PKK+zdmqlRFRX5AKCHOIRb2Vgy3MmVYtVn7mtDF+DtOH7l3z5Y7QGj4LGwumirMo3v ir/etrZxykJSEDXSoMqjBUQdlZ9jchJZWfrBoss4R77JM6QmtOOCGtZXqwL9UUuB1+6o YOX8CeOCiM6OpTl+5HiCwW03IlT75Idg4tG0cWm0xsIy8wiodLha/HUk9lZORka7Bi8N 5KblBONkNyVPWfM3yCtIlpxNbP5m6S1wtf1IZxNtw5rogPkr11mXeowpZysrE/luyZmL rMjHIq8dqm2va/RAkuYiUKJ6DL3fyNL6nX8cgKMQZRPJm61xkKaAXmFUXyhMW3DCLO+/ j/dw== X-Gm-Message-State: AOAM530muL+uPhgzCQiI3BChSEeDvAeSXQ2Nkl5bmN4l9ZdpWick2zN0 hVCjf4y6uaknOmVDyOOzOoehImuzqktBqA== X-Google-Smtp-Source: ABdhPJwBxGRA5BzxUprjvVZ8kygr0E5EG3P3en07a5JNLMmf0jzjEvOZCkqiG7fABXaozfGWQ981Zg== X-Received: by 2002:a17:90a:d3d6:: with SMTP id d22mr9466546pjw.242.1632155055140; Mon, 20 Sep 2021 09:24:15 -0700 (PDT) Received: from [192.168.1.11] ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id v13sm14977546pfm.16.2021.09.20.09.24.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 09:24:14 -0700 (PDT) Subject: Re: [PATCH 20/30] tcg/loongarch: Implement setcond ops To: WANG Xuerui , qemu-devel@nongnu.org References: <20210920080451.408655-1-git@xen0n.name> <20210920080451.408655-21-git@xen0n.name> From: Richard Henderson Message-ID: <523333d4-5e5b-aa83-db04-fe9562a13d13@linaro.org> Date: Mon, 20 Sep 2021 09:24:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210920080451.408655-21-git@xen0n.name> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/20/21 1:04 AM, WANG Xuerui wrote: > + switch (cond) { > + case TCG_COND_EQ: > + tcg_out_opc_sub_d(s, ret, arg1, arg2); > + tcg_out_opc_sltui(s, ret, ret, 1); > + break; > + case TCG_COND_NE: > + tcg_out_opc_sub_d(s, ret, arg1, arg2); > + tcg_out_opc_sltu(s, ret, TCG_REG_ZERO, ret); > + break; You accept zero as input; you'll want to skip the subtract in that case. r~