From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 18 Apr 2017 12:58:26 +0200 Subject: [U-Boot] [PATCH v5 14/16] arm: socfpga: Add config and defconfig for Arria 10 In-Reply-To: References: <1492105285-2804-1-git-send-email-ley.foon.tan@intel.com> <1492105285-2804-15-git-send-email-ley.foon.tan@intel.com> <8b6dd3ff-1742-b022-75f8-5efb15b6c210@denx.de> <24a903c0-b51e-8ccf-16cb-a939726eb0eb@denx.de> Message-ID: <5247b499-fb5b-43b3-4731-f093f192fe73@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/18/2017 05:12 AM, Ley Foon Tan wrote: > On Mon, Apr 17, 2017 at 6:39 PM, Marek Vasut wrote: >> On 04/17/2017 05:05 AM, Ley Foon Tan wrote: >>> On Fri, Apr 14, 2017 at 6:25 PM, Marek Vasut wrote: >>>> On 04/13/2017 07:41 PM, Ley Foon Tan wrote: >>>>> Add config and defconfig for the Arria10 and update socfpga_common.h. >>>>> >>>>> Signed-off-by: Tien Fong Chee >>>>> Signed-off-by: Ley Foon Tan >>>> >>>> [...] >>>> >>>>> @@ -298,7 +306,10 @@ unsigned int cm_get_qspi_controller_clk_hz(void); >>>>> */ >>>>> #define CONFIG_SPL_FRAMEWORK >>>>> #define CONFIG_SPL_TEXT_BASE CONFIG_SYS_INIT_RAM_ADDR >>>>> -#define CONFIG_SPL_MAX_SIZE (64 * 1024) >>>>> +#define CONFIG_SPL_MAX_SIZE CONFIG_SYS_INIT_RAM_SIZE >>>>> +#if defined(CONFIG_TARGET_SOCFPGA_ARRIA10) >>>>> +#define CONFIG_SPL_BOARD_INIT >>>> >>>> This should be in Kconfig and selected by arch/arm/mach-socfpga/Kconfig >>>> entry for A10 >>> We can't use Kconfig method for CONFIG_SPL_BOARD_INIT, it is not a >>> Kconfig parameter now. >> >> OK. You can turn it into one, although that is out of the scope of this >> patchset. > Okay, I will add SPL_BOARD_INIT to arch/arm/mach-socfpga/Kconfig and > select it for Arria 10. Do it in a separate patch please . Also, there's a script for turning symbols into Kconfig symbols in u-boot. -- Best regards, Marek Vasut