From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 2/7] drivers/net/e1000: Fix missing
	brackets
Date: Wed, 23 Mar 2016 11:38:14 +0100
Message-ID: <5248499.WRMHcbhMjp@xps13>
References: <1458682638-28378-1-git-send-email-aconole@redhat.com>
 <1458682638-28378-3-git-send-email-aconole@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Aaron Conole <aconole@redhat.com>, dev@dpdk.org
To: Wenzhuo Lu <wenzhou.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 196CF2A5E
 for <dev@dpdk.org>; Wed, 23 Mar 2016 11:39:56 +0100 (CET)
Received: by mail-wm0-f48.google.com with SMTP id p65so227581459wmp.1
 for <dev@dpdk.org>; Wed, 23 Mar 2016 03:39:56 -0700 (PDT)
In-Reply-To: <1458682638-28378-3-git-send-email-aconole@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-22 17:37, Aaron Conole:
> The register read/write mphy functions have misleading whitespace around
> the locked check. This cleanup merely preserves the existing functionality
> while improving the ready check.
> 
> Fixes commit 38db3f7f50bd ("e1000: update base driver")
> 
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
> v2:
> * Changed from "whitespace-only" fix to a functional change
>   moving the phy writes into protection of the `if (locked)`
>   code
> * Added "Fixes" line.

Wenzhuo, do you agree to fix the base driver here?