From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org,
Frediano Ziglio <frediano.ziglio@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
linux-kernel@vger.kernel.org,
David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] xen: Fix possible user space selector corruption
Date: Fri, 4 Oct 2013 14:33:53 +0100 [thread overview]
Message-ID: <524EC3C1.4010304__44695.7124433995$1380894776$gmane$org@citrix.com> (raw)
In-Reply-To: <20131004132033.GA26673@phenom.dumpdata.com>
On 04/10/13 14:20, Konrad Rzeszutek Wilk wrote:
> On Thu, Oct 03, 2013 at 01:51:32PM +0100, Frediano Ziglio wrote:
>> On Thu, 2013-10-03 at 11:04 +0100, Andrew Cooper wrote:
>>> On 03/10/13 09:24, Frediano Ziglio wrote:
>>>>
>>>> Bisecting the code commit 7076aada1040de4ed79a5977dbabdb5e5ea5e249 appears
>>>> to be the first one that have this issue.
>>>>
>>>> Signed-off-by: Frediano Ziglio <frediano.ziglio@citrix.com>
>>> In terms of the correctness of the fix,
>>>
>>> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Should this also go in stable tree?
Very much so. The change which exposed it for us was from 3.7 iirc, but
I believe it has been a latent bug for as long as the native early boot
code uses __USER_DS.
>>> However, I am not sure the comment is necessary. The prevailing style
>>> is for no justification of loads of segment selectors on boot, and the
>>> comment itself refers simply to an interaction issue of 32bit on Xen
>>> when making use of sysenter.
>>>
>> Suggestion for the comment ??
>>
>> Frediano
My suggestion was to omit the comment entirely, or simplify it to just:
/* Xen starts us with XEN_FLAT_RING1_DS, but linux code expects __USER_DS */
Anyone who wants the full explanation can read the patch description.
~Andrew
next prev parent reply other threads:[~2013-10-04 13:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 8:24 [PATCH] xen: Fix possible user space selector corruption Frediano Ziglio
2013-10-03 9:47 ` [Xen-devel] " David Vrabel
2013-10-03 9:47 ` David Vrabel
2013-10-03 10:04 ` Andrew Cooper
2013-10-03 10:04 ` [Xen-devel] " Andrew Cooper
2013-10-03 12:51 ` Frediano Ziglio
2013-10-04 13:20 ` Konrad Rzeszutek Wilk
2013-10-04 13:20 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-10-04 13:33 ` Andrew Cooper
2013-10-07 9:39 ` David Vrabel
2013-10-07 9:39 ` [Xen-devel] " David Vrabel
2013-10-07 9:48 ` [PATCH v2] " Frediano Ziglio
2013-10-07 9:48 ` Frediano Ziglio
2013-10-07 9:49 ` Andrew Cooper
2013-10-07 9:49 ` Andrew Cooper
2013-10-04 13:33 ` Andrew Cooper [this message]
2013-10-03 12:51 ` [PATCH] " Frediano Ziglio
2013-10-03 8:24 Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='524EC3C1.4010304__44695.7124433995$1380894776$gmane$org@citrix.com' \
--to=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=frediano.ziglio@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.