From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS9as-0002oE-3h for qemu-devel@nongnu.org; Fri, 04 Oct 2013 13:55:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VS9am-0003ap-M0 for qemu-devel@nongnu.org; Fri, 04 Oct 2013 13:55:14 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41580 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VS9am-0003aB-G0 for qemu-devel@nongnu.org; Fri, 04 Oct 2013 13:55:08 -0400 Message-ID: <524F00F6.1020702@suse.de> Date: Fri, 04 Oct 2013 19:55:02 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1380905823-3981-1-git-send-email-chouteau@adacore.com> <1380905823-3981-4-git-send-email-chouteau@adacore.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Fabien Chouteau Cc: QEMU Developers , Luiz Capitulino Am 04.10.2013 19:49, schrieb Peter Maydell: > On 5 October 2013 01:57, Fabien Chouteau wrote: >=20 >> --- a/target-sparc/cpu-qom.h >> +++ b/target-sparc/cpu-qom.h >> @@ -21,7 +21,6 @@ >> #define QEMU_SPARC_CPU_QOM_H >> >> #include "qom/cpu.h" >> -#include "cpu.h" >=20 > ...why have you deleted this #include ? That's removing a circular include, I guess. If I get it as a separate patch I would apply it immediately ... well, in quotes, sorry... Andreas >> >> #ifdef TARGET_SPARC64 >> #define TYPE_SPARC_CPU "sparc64-cpu" --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg