From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Cousson Subject: Re: [PATCH 1/3] ARM: dts: omap3-igep0020: Add USB OTG support Date: Mon, 07 Oct 2013 13:58:34 +0200 Message-ID: <5252A1EA.9020909@baylibre.com> References: <1380931479-16142-1-git-send-email-javier.martinez@collabora.co.uk> <1380931479-16142-2-git-send-email-javier.martinez@collabora.co.uk> <52529048.1040606@ti.com> <5252A0FE.5070809@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f180.google.com ([209.85.215.180]:40352 "EHLO mail-ea0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755691Ab3JGL6i (ORCPT ); Mon, 7 Oct 2013 07:58:38 -0400 Received: by mail-ea0-f180.google.com with SMTP id h10so3141999eaj.39 for ; Mon, 07 Oct 2013 04:58:37 -0700 (PDT) In-Reply-To: <5252A0FE.5070809@collabora.co.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Javier Martinez Canillas Cc: Roger Quadros , Tony Lindgren , Enric Balletbo i Serra , linux-omap@vger.kernel.org Hi Javier, On 07/10/2013 13:54, Javier Martinez Canillas wrote: > On 10/07/2013 12:43 PM, Roger Quadros wrote: >> Javier, >> >> On 10/05/2013 03:04 AM, Javier Martinez Canillas wrote: >>> Commit ad871c10b ("ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards") >>> added USB OTG support for most OMAP boards but some OMAP3 boards >>> such as the IGEPv2 were not updated. This patch adds an USB OTG >>> device node to this board. >>> >>> Signed-off-by: Javier Martinez Canillas >>> --- >>> arch/arm/boot/dts/omap3-igep0020.dts | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/omap3-igep0020.dts b/arch/arm/boot/dts/omap3-igep0020.dts >>> index eedf0d8..903e944 100644 >>> --- a/arch/arm/boot/dts/omap3-igep0020.dts >>> +++ b/arch/arm/boot/dts/omap3-igep0020.dts >>> @@ -166,3 +166,10 @@ >>> smsc,save-mac-address; >>> }; >>> }; >>> + >>> +&usb_otg_hs { >>> + interface-type = <0>; >>> + usb-phy = <&usb2_phy>; >> >> With the PHY generic framework in Greg's usb-next branch [1], you will also need to add >> >> + phys = <&usb2_phy>; >> + phy-names = "usb2-phy"; >> >>> + mode = <3>; >>> + power = <50>; >>> +}; >>> >> >> So it would be good to test with the usb-next branch. >> >> cheers, >> -roger >> >> [1] - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git >> > > Hi Roger, > > Thanks for the pointer, I'll add those properties and test using the PHY generic > framework. Should I expect a v3 then? Benoit