From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AED4CC433E0 for ; Mon, 1 Mar 2021 11:53:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63E1D64EDF for ; Mon, 1 Mar 2021 11:53:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234148AbhCALxL (ORCPT ); Mon, 1 Mar 2021 06:53:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234483AbhCALwt (ORCPT ); Mon, 1 Mar 2021 06:52:49 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B169AC061756 for ; Mon, 1 Mar 2021 03:52:33 -0800 (PST) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 505E28AF; Mon, 1 Mar 2021 12:52:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1614599549; bh=5rg8vgJJDo04x0ejCMCvhSAcjOkn0AsieQ+bu+5f2Ng=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=g92PFj7GCgpg7Tb5Vj2bkCZPuiaaw8ixaOes3hNVJDTiyfSHQwiK/fbolWsDAK6S1 NkLLTAAk/FuJJQAYyvO2VWnvrfKDc87F1a7ALe0Y+uj2ZUeERYUv+ZRjL8AGitIp6v oND+pBTK4oqwkT/64FlSgH9E/KNgw7xhrSnUpprA= Reply-To: kieran.bingham+renesas@ideasonboard.com Subject: Re: [PATCH] drm: rcar-du: Use drmm_encoder_alloc() to manage encoder To: Geert Uytterhoeven , Laurent Pinchart Cc: David Airlie , Daniel Vetter , DRI Development , Linux-Renesas , Geert Uytterhoeven References: <20210113170253.443820-1-kieran.bingham+renesas@ideasonboard.com> From: Kieran Bingham Organization: Ideas on Board Message-ID: <5252aceb-75f9-52d9-cba2-9ecc017698d8@ideasonboard.com> Date: Mon, 1 Mar 2021 11:52:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Laurent, On 01/03/2021 10:30, Geert Uytterhoeven wrote: > On Thu, Jan 14, 2021 at 11:00 AM Geert Uytterhoeven > wrote: >> On Wed, Jan 13, 2021 at 6:02 PM Kieran Bingham >> wrote: >>> The encoder allocation was converted to a DRM managed resource at the >>> same time as the addition of a new helper drmm_encoder_alloc() which >>> simplifies the same process. >>> >>> Convert the custom drm managed resource allocation of the encoder >>> with the helper to simplify the implementation, and prevent hitting a >>> WARN_ON() due to the handling the drm_encoder_init() call directly >>> without registering a .destroy() function op. >>> >>> Fixes: f5f16725edbc ("drm: rcar-du: Use DRM-managed allocation for encoders") >>> Reported-by: Geert Uytterhoeven >>> Signed-off-by: Kieran Bingham >> >> Tested-by: Geert Uytterhoeven >> As in "the WARNING from drm_encoder_init() is gone". > > JFYI, the WARNING is now in v5.12-rc1, the fix isn't. Does this patch go through you to get into the DRM tree? Or do I need to re-send it to someone else? > Gr{oetje,eeting}s, > > Geert > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11EBAC433E9 for ; Mon, 1 Mar 2021 11:52:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B45764ED7 for ; Mon, 1 Mar 2021 11:52:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B45764ED7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9274789F89; Mon, 1 Mar 2021 11:52:33 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id D53B889F89 for ; Mon, 1 Mar 2021 11:52:31 +0000 (UTC) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 505E28AF; Mon, 1 Mar 2021 12:52:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1614599549; bh=5rg8vgJJDo04x0ejCMCvhSAcjOkn0AsieQ+bu+5f2Ng=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=g92PFj7GCgpg7Tb5Vj2bkCZPuiaaw8ixaOes3hNVJDTiyfSHQwiK/fbolWsDAK6S1 NkLLTAAk/FuJJQAYyvO2VWnvrfKDc87F1a7ALe0Y+uj2ZUeERYUv+ZRjL8AGitIp6v oND+pBTK4oqwkT/64FlSgH9E/KNgw7xhrSnUpprA= Subject: Re: [PATCH] drm: rcar-du: Use drmm_encoder_alloc() to manage encoder To: Geert Uytterhoeven , Laurent Pinchart References: <20210113170253.443820-1-kieran.bingham+renesas@ideasonboard.com> From: Kieran Bingham Organization: Ideas on Board Message-ID: <5252aceb-75f9-52d9-cba2-9ecc017698d8@ideasonboard.com> Date: Mon, 1 Mar 2021 11:52:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: kieran.bingham+renesas@ideasonboard.com Cc: David Airlie , Linux-Renesas , Geert Uytterhoeven , DRI Development Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Laurent, On 01/03/2021 10:30, Geert Uytterhoeven wrote: > On Thu, Jan 14, 2021 at 11:00 AM Geert Uytterhoeven > wrote: >> On Wed, Jan 13, 2021 at 6:02 PM Kieran Bingham >> wrote: >>> The encoder allocation was converted to a DRM managed resource at the >>> same time as the addition of a new helper drmm_encoder_alloc() which >>> simplifies the same process. >>> >>> Convert the custom drm managed resource allocation of the encoder >>> with the helper to simplify the implementation, and prevent hitting a >>> WARN_ON() due to the handling the drm_encoder_init() call directly >>> without registering a .destroy() function op. >>> >>> Fixes: f5f16725edbc ("drm: rcar-du: Use DRM-managed allocation for encoders") >>> Reported-by: Geert Uytterhoeven >>> Signed-off-by: Kieran Bingham >> >> Tested-by: Geert Uytterhoeven >> As in "the WARNING from drm_encoder_init() is gone". > > JFYI, the WARNING is now in v5.12-rc1, the fix isn't. Does this patch go through you to get into the DRM tree? Or do I need to re-send it to someone else? > Gr{oetje,eeting}s, > > Geert > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel