From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTjob-0007Hi-6h for Qemu-devel@nongnu.org; Tue, 08 Oct 2013 22:48:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VTjoW-000193-Ag for Qemu-devel@nongnu.org; Tue, 08 Oct 2013 22:47:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VTjoW-00018s-0g for Qemu-devel@nongnu.org; Tue, 08 Oct 2013 22:47:52 -0400 Message-ID: <5254C3D3.9070304@redhat.com> Date: Tue, 08 Oct 2013 20:47:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1381286246-29818-1-git-send-email-wudxw@linux.vnet.ibm.com> In-Reply-To: <1381286246-29818-1-git-send-email-wudxw@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jL2soTU9arxW0UgakKPrUkQWDj1GeGLvB" Subject: Re: [Qemu-devel] [PATCH v5] Extend qemu-ga's 'guest-info' command to expose flag 'success-response' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Wu Cc: Michael Roth , Qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jL2soTU9arxW0UgakKPrUkQWDj1GeGLvB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/08/2013 08:37 PM, Mark Wu wrote: > Now we have several qemu-ga commands not returning response on success.= > It has been documented in qga/qapi-schema.json already. This patch expo= ses > the 'success-response' flag by extending 'guest-info' command. With thi= s > change, the clients can handle the command response more flexibly. >=20 > Signed-off-by: Mark Wu > --- > v5: > Fix a tab indent and rebase=20 > v4:=20 > Add signature of qmp_has_success_response per Michael. > v3:=20 > 1. treat cmd->options as a bitmask instead of single option (per Eric)= =20 > 2. rebase on the patch " Add interface to traverse the qmp command lis= t > by QmpCommand" to avoid the O(n2) problem (per Eric and Michael) > v2:=20 > add the notation 'since 1.7' to the option 'success-response' > (per Eric Blake's comments) >=20 > include/qapi/qmp/dispatch.h | 1 + > qapi/qmp-registry.c | 5 +++++ > qga/commands.c | 1 + > qga/qapi-schema.json | 5 ++++- > 4 files changed, 11 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jL2soTU9arxW0UgakKPrUkQWDj1GeGLvB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSVMPTAAoJEKeha0olJ0NqGAkH/R52nt+jGg3dL2u06ly58dS4 A51kDk2IagO5cAYxcCxDLK3B30bj9z9FspYTp/+mat1C7VMDnCCTBYuDVwKKRIUT cIvq2s/8uKLyWWzD7AMAaIr/2kNKdDQKT0ngXv+gQ7ueTBJnXHttpa1V+MBhMHjr MbybS3o0tQa4pHRzcf8Scx5lkT4FBye3LpZLfBlgGy+iwfK6vx8ClFmCOgchsTbA QI2A4vCMzzwAIeC9y50cws6fpvhwd4VU5ZBh4PW6USfsX0t0yEtys+JJGH/LEEnG 1e1ZJe77vGbWHd7h55byByC2xFV0LNEJIGTS3mdnZsh0FsZQaDuTqSLmQcPfN5Q= =rYFW -----END PGP SIGNATURE----- --jL2soTU9arxW0UgakKPrUkQWDj1GeGLvB--