From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:47039 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754479AbeDYKrk (ORCPT ); Wed, 25 Apr 2018 06:47:40 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180425104738euoutp01a1bbe09b476c13e39e9e80aa03a3c91b~oqA99Fc2Y1388013880euoutp01k for ; Wed, 25 Apr 2018 10:47:38 +0000 (GMT) From: Bartlomiej Zolnierkiewicz To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Mauro Carvalho Chehab , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Laurent Pinchart , Tomi Valkeinen Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Date: Wed, 25 Apr 2018 12:47:34 +0200 Message-ID: <52576986.R85hrt8lfa@amdc3058> In-Reply-To: <20180423105557.267c5ecf@vento.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" References: <2542100.cElVns0SR0@amdc3058> <20180423105557.267c5ecf@vento.lan> Sender: linux-media-owner@vger.kernel.org List-ID: On Monday, April 23, 2018 10:55:57 AM Mauro Carvalho Chehab wrote: > Em Mon, 23 Apr 2018 14:47:28 +0200 > Bartlomiej Zolnierkiewicz escreveu: > > > On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > > > Add stubs for omapfb_dss.h, in the case it is included by > > > some driver when CONFIG_FB_OMAP2 is not defined, with can > > > happen on ARM when DRM_OMAP is not 'n'. > > > > > > That allows building such driver(s) with COMPILE_TEST. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > > This patch should be dropped (together with patch #6/7) as it was > > superseded by a better solution suggested by Laurent: > > > > https://patchwork.kernel.org/patch/10325193/ > > > > ACK-ed by Tomi: > > > > https://www.spinics.net/lists/dri-devel/msg171918.html > > > > and already merged by you (commit 7378f1149884 "media: omap2: > > omapfb: allow building it with COMPILE_TEST").. > > I "ressurected" this patch due to patch 6/7. > > The problem with the solution already acked/merged is that > it works *only* if you don't try to build for ARM. > > At the moment you want to build a FB_OMAP2-dependent driver > on ARM with allyesc onfig, DRM_OMAP will be true, and FB_OMAP2 > will be disabled: > > menuconfig FB_OMAP2 > tristate "OMAP2+ frame buffer support" > depends on FB > depends on DRM_OMAP = n > > One solution might be to change the depends on to: > depends on (DRM_OMAP = n || COMPILE_TEST) > > But someone pointed me that the above check was added to avoid building > duplicated symbols. So, the above would cause build failures. > > So, in order to build for ARM with DRM_OMAP selected (allyesconfig, > allmodconfig), we have the following alternatives: > > 1) apply patch 5/7; > 2) make sure that FB_OMAP2 and DRM_OMAP won't declare the > same non-static symbols; > 3) redesign FB_OMAP2 to work with DRM_OMAP built. > > I suspect that (1) is easier. I agree. You can merge this patch through your tree with: Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Wed, 25 Apr 2018 10:47:34 +0000 Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Message-Id: <52576986.R85hrt8lfa@amdc3058> List-Id: References: <2542100.cElVns0SR0@amdc3058> <20180423105557.267c5ecf@vento.lan> In-Reply-To: <20180423105557.267c5ecf@vento.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mauro Carvalho Chehab Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Tomi Valkeinen , Laurent Pinchart , Linux Media Mailing List On Monday, April 23, 2018 10:55:57 AM Mauro Carvalho Chehab wrote: > Em Mon, 23 Apr 2018 14:47:28 +0200 > Bartlomiej Zolnierkiewicz escreveu: > > > On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote: > > > Add stubs for omapfb_dss.h, in the case it is included by > > > some driver when CONFIG_FB_OMAP2 is not defined, with can > > > happen on ARM when DRM_OMAP is not 'n'. > > > > > > That allows building such driver(s) with COMPILE_TEST. > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > > This patch should be dropped (together with patch #6/7) as it was > > superseded by a better solution suggested by Laurent: > > > > https://patchwork.kernel.org/patch/10325193/ > > > > ACK-ed by Tomi: > > > > https://www.spinics.net/lists/dri-devel/msg171918.html > > > > and already merged by you (commit 7378f1149884 "media: omap2: > > omapfb: allow building it with COMPILE_TEST").. > > I "ressurected" this patch due to patch 6/7. > > The problem with the solution already acked/merged is that > it works *only* if you don't try to build for ARM. > > At the moment you want to build a FB_OMAP2-dependent driver > on ARM with allyesc onfig, DRM_OMAP will be true, and FB_OMAP2 > will be disabled: > > menuconfig FB_OMAP2 > tristate "OMAP2+ frame buffer support" > depends on FB > depends on DRM_OMAP = n > > One solution might be to change the depends on to: > depends on (DRM_OMAP = n || COMPILE_TEST) > > But someone pointed me that the above check was added to avoid building > duplicated symbols. So, the above would cause build failures. > > So, in order to build for ARM with DRM_OMAP selected (allyesconfig, > allmodconfig), we have the following alternatives: > > 1) apply patch 5/7; > 2) make sure that FB_OMAP2 and DRM_OMAP won't declare the > same non-static symbols; > 3) redesign FB_OMAP2 to work with DRM_OMAP built. > > I suspect that (1) is easier. I agree. You can merge this patch through your tree with: Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 5/7] omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP Date: Wed, 25 Apr 2018 12:47:34 +0200 Message-ID: <52576986.R85hrt8lfa@amdc3058> References: <2542100.cElVns0SR0@amdc3058> <20180423105557.267c5ecf@vento.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD3A46E103 for ; Wed, 25 Apr 2018 10:47:40 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180425104737euoutp02b4f474a6227ed402990516e3ed628d30~oqA9Yxxn03101431014euoutp027 for ; Wed, 25 Apr 2018 10:47:37 +0000 (GMT) In-Reply-To: <20180423105557.267c5ecf@vento.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mauro Carvalho Chehab Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Tomi Valkeinen , Laurent Pinchart , Linux Media Mailing List List-Id: dri-devel@lists.freedesktop.org T24gTW9uZGF5LCBBcHJpbCAyMywgMjAxOCAxMDo1NTo1NyBBTSBNYXVybyBDYXJ2YWxobyBDaGVo YWIgd3JvdGU6Cj4gRW0gTW9uLCAyMyBBcHIgMjAxOCAxNDo0NzoyOCArMDIwMAo+IEJhcnRsb21p ZWogWm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBzYW1zdW5nLmNvbT4gZXNjcmV2ZXU6Cj4g Cj4gPiBPbiBGcmlkYXksIEFwcmlsIDIwLCAyMDE4IDAxOjQyOjUxIFBNIE1hdXJvIENhcnZhbGhv IENoZWhhYiB3cm90ZToKPiA+ID4gQWRkIHN0dWJzIGZvciBvbWFwZmJfZHNzLmgsIGluIHRoZSBj YXNlIGl0IGlzIGluY2x1ZGVkIGJ5Cj4gPiA+IHNvbWUgZHJpdmVyIHdoZW4gQ09ORklHX0ZCX09N QVAyIGlzIG5vdCBkZWZpbmVkLCB3aXRoIGNhbgo+ID4gPiBoYXBwZW4gb24gQVJNIHdoZW4gRFJN X09NQVAgaXMgbm90ICduJy4KPiA+ID4gCj4gPiA+IFRoYXQgYWxsb3dzIGJ1aWxkaW5nIHN1Y2gg ZHJpdmVyKHMpIHdpdGggQ09NUElMRV9URVNULgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTog TWF1cm8gQ2FydmFsaG8gQ2hlaGFiIDxtY2hlaGFiQHMtb3BlbnNvdXJjZS5jb20+ICAKPiA+IAo+ ID4gVGhpcyBwYXRjaCBzaG91bGQgYmUgZHJvcHBlZCAodG9nZXRoZXIgd2l0aCBwYXRjaCAjNi83 KSBhcyBpdCB3YXMKPiA+IHN1cGVyc2VkZWQgYnkgYSBiZXR0ZXIgc29sdXRpb24gc3VnZ2VzdGVk IGJ5IExhdXJlbnQ6Cj4gPiAKPiA+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gv MTAzMjUxOTMvCj4gPiAKPiA+IEFDSy1lZCBieSBUb21pOgo+ID4gCj4gPiBodHRwczovL3d3dy5z cGluaWNzLm5ldC9saXN0cy9kcmktZGV2ZWwvbXNnMTcxOTE4Lmh0bWwKPiA+IAo+ID4gYW5kIGFs cmVhZHkgbWVyZ2VkIGJ5IHlvdSAoY29tbWl0IDczNzhmMTE0OTg4NCAibWVkaWE6IG9tYXAyOgo+ ID4gb21hcGZiOiBhbGxvdyBidWlsZGluZyBpdCB3aXRoIENPTVBJTEVfVEVTVCIpLi4KPiAKPiBJ ICJyZXNzdXJlY3RlZCIgdGhpcyBwYXRjaCBkdWUgdG8gcGF0Y2ggNi83Lgo+IAo+IFRoZSBwcm9i bGVtIHdpdGggdGhlIHNvbHV0aW9uIGFscmVhZHkgYWNrZWQvbWVyZ2VkIGlzIHRoYXQKPiBpdCB3 b3JrcyAqb25seSogaWYgeW91IGRvbid0IHRyeSB0byBidWlsZCBmb3IgQVJNLgo+IAo+IEF0IHRo ZSBtb21lbnQgeW91IHdhbnQgdG8gYnVpbGQgYSBGQl9PTUFQMi1kZXBlbmRlbnQgZHJpdmVyCj4g b24gQVJNIHdpdGggYWxseWVzYyBvbmZpZywgRFJNX09NQVAgd2lsbCBiZSB0cnVlLCBhbmQgRkJf T01BUDIKPiB3aWxsIGJlIGRpc2FibGVkOgo+IAo+IAltZW51Y29uZmlnIEZCX09NQVAyCj4gICAg ICAgICAJdHJpc3RhdGUgIk9NQVAyKyBmcmFtZSBidWZmZXIgc3VwcG9ydCIKPiAJICAgICAgICBk ZXBlbmRzIG9uIEZCCj4gICAgICAgICAJZGVwZW5kcyBvbiBEUk1fT01BUCA9IG4KPiAKPiBPbmUg c29sdXRpb24gbWlnaHQgYmUgdG8gY2hhbmdlIHRoZSBkZXBlbmRzIG9uIHRvOgo+ICAgICAgICAg CWRlcGVuZHMgb24gKERSTV9PTUFQID0gbiB8fCBDT01QSUxFX1RFU1QpCj4gCj4gQnV0IHNvbWVv bmUgcG9pbnRlZCBtZSB0aGF0IHRoZSBhYm92ZSBjaGVjayB3YXMgYWRkZWQgdG8gYXZvaWQgYnVp bGRpbmcKPiBkdXBsaWNhdGVkIHN5bWJvbHMuIFNvLCB0aGUgYWJvdmUgd291bGQgY2F1c2UgYnVp bGQgZmFpbHVyZXMuCj4gCj4gU28sIGluIG9yZGVyIHRvIGJ1aWxkIGZvciBBUk0gd2l0aCBEUk1f T01BUCBzZWxlY3RlZCAoYWxseWVzY29uZmlnLAo+IGFsbG1vZGNvbmZpZyksIHdlIGhhdmUgdGhl IGZvbGxvd2luZyBhbHRlcm5hdGl2ZXM6Cj4gCj4gCTEpIGFwcGx5IHBhdGNoIDUvNzsKPiAJMikg bWFrZSBzdXJlIHRoYXQgRkJfT01BUDIgYW5kIERSTV9PTUFQIHdvbid0IGRlY2xhcmUgdGhlCj4g CSAgIHNhbWUgbm9uLXN0YXRpYyBzeW1ib2xzOwo+IAkzKSByZWRlc2lnbiBGQl9PTUFQMiB0byB3 b3JrIHdpdGggRFJNX09NQVAgYnVpbHQuCj4gCj4gSSBzdXNwZWN0IHRoYXQgKDEpIGlzIGVhc2ll ci4KCkkgYWdyZWUuCgpZb3UgY2FuIG1lcmdlIHRoaXMgcGF0Y2ggdGhyb3VnaCB5b3VyIHRyZWUg d2l0aDoKCkFja2VkLWJ5OiBCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVA c2Ftc3VuZy5jb20+CgpCZXN0IHJlZ2FyZHMsCi0tCkJhcnRsb21pZWogWm9sbmllcmtpZXdpY3oK U2Ftc3VuZyBSJkQgSW5zdGl0dXRlIFBvbGFuZApTYW1zdW5nIEVsZWN0cm9uaWNzCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK