All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 03/12] ui/gtk-clipboard: use existing macros
Date: Mon, 19 Jul 2021 11:13:53 +0200	[thread overview]
Message-ID: <525e964c-f91f-813f-736f-e8d888f44a36@redhat.com> (raw)
In-Reply-To: <20210719072654.845901-4-marcandre.lureau@redhat.com>

On 7/19/21 9:26 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Rather than hardcoding strings

Why not write a full sentence? It is only 3 words saved, and
we could directly understand the comment without having to
look at the subject.

> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  ui/gtk-clipboard.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ui/gtk-clipboard.c b/ui/gtk-clipboard.c
> index bff28d2030..5e817ae55c 100644
> --- a/ui/gtk-clipboard.c
> +++ b/ui/gtk-clipboard.c
> @@ -177,11 +177,11 @@ void gd_clipboard_init(GtkDisplayState *gd)
>      qemu_clipboard_peer_register(&gd->cbpeer);
>  
>      gd->gtkcb[QEMU_CLIPBOARD_SELECTION_CLIPBOARD] =
> -        gtk_clipboard_get(gdk_atom_intern("CLIPBOARD", FALSE));
> +        gtk_clipboard_get(GDK_SELECTION_CLIPBOARD);
>      gd->gtkcb[QEMU_CLIPBOARD_SELECTION_PRIMARY] =
> -        gtk_clipboard_get(gdk_atom_intern("PRIMARY", FALSE));
> +        gtk_clipboard_get(GDK_SELECTION_PRIMARY);
>      gd->gtkcb[QEMU_CLIPBOARD_SELECTION_SECONDARY] =
> -        gtk_clipboard_get(gdk_atom_intern("SECONDARY", FALSE));
> +        gtk_clipboard_get(GDK_SELECTION_SECONDARY);
>  
>      g_signal_connect(gd->gtkcb[QEMU_CLIPBOARD_SELECTION_CLIPBOARD],
>                       "owner-change", G_CALLBACK(gd_owner_change), gd);
> 



  reply	other threads:[~2021-07-19  9:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19  7:26 [PATCH 00/12] Clipboard fixes (for 6.1?) marcandre.lureau
2021-07-19  7:26 ` [PATCH 01/12] ui/vdagent: fix leak on error path marcandre.lureau
2021-07-19  7:26 ` [PATCH 02/12] ui/vdagent: remove copy-pasta comment marcandre.lureau
2021-07-19  7:26 ` [PATCH 03/12] ui/gtk-clipboard: use existing macros marcandre.lureau
2021-07-19  9:13   ` Philippe Mathieu-Daudé [this message]
2021-07-19  7:26 ` [PATCH 04/12] ui/gtk-clipboard: fix clipboard enum typo marcandre.lureau
2021-07-19  7:26 ` [PATCH 05/12] ui/clipboard: add helper to retrieve current clipboard marcandre.lureau
2021-07-19  7:26 ` [PATCH 06/12] ui/clipboard: release owned grabs on unregister marcandre.lureau
2021-07-19  7:26 ` [PATCH 07/12] ui/vdagent: unregister clipboard peer on finalize marcandre.lureau
2021-07-21  8:24   ` Marc-André Lureau
2021-07-19  7:26 ` [PATCH 08/12] ui/vdagent: split clipboard recv message handling marcandre.lureau
2021-07-19  7:26 ` [PATCH 09/12] ui/vdagent: use qemu_clipboard_info helper marcandre.lureau
2021-07-19  7:26 ` [PATCH 10/12] ui/gtk-clipboard: " marcandre.lureau
2021-07-19  7:26 ` [PATCH 11/12] ui/vdagent: send release when no clipboard owner marcandre.lureau
2021-07-19  7:26 ` [PATCH 12/12] ui/gtk-clipboard: emit release clipboard events marcandre.lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525e964c-f91f-813f-736f-e8d888f44a36@redhat.com \
    --to=philmd@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.