From: Richard Henderson <richard.henderson@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>, qemu-devel@nongnu.org
Cc: "Cédric Le Goater" <clg@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH for-8.0 v2 2/3] target/s390x: Fix float_comp_to_cc() prototype
Date: Tue, 21 Mar 2023 20:54:15 -0700 [thread overview]
Message-ID: <52635c3b-ced1-8310-ece6-b97a7d4a0aad@linaro.org> (raw)
In-Reply-To: <20230321161609.716474-3-clg@kaod.org>
On 3/21/23 09:16, Cédric Le Goater wrote:
> From: Cédric Le Goater <clg@redhat.com>
>
> GCC13 reports an error :
>
> ../target/s390x/tcg/fpu_helper.c:123:5: error: conflicting types for ‘float_comp_to_cc’ due to enum/integer mismatch; have ‘int(CPUS390XState *, FloatRelation)’ {aka ‘int(struct CPUArchState *, FloatRelation)’} [-Werror=enum-int-mismatch]
>
> 123 | int float_comp_to_cc(CPUS390XState *env, FloatRelation float_compare)
> | ^~~~~~~~~~~~~~~~
> In file included from ../target/s390x/tcg/fpu_helper.c:23:
> ../target/s390x/s390x-internal.h:302:5: note: previous declaration of ‘float_comp_to_cc’ with type ‘int(CPUS390XState *, int)’ {aka ‘int(struct CPUArchState *, int)’}
> 302 | int float_comp_to_cc(CPUS390XState *env, int float_compare);
> | ^~~~~~~~~~~~~~~~
>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Ilya Leoshkevich <iii@linux.ibm.com>
> Fixes: 71bfd65c5f ("softfloat: Name compare relation enum")
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-03-22 3:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 16:16 [PATCH for-8.0 v2 0/3] Fixes for GCC13 Cédric Le Goater
2023-03-21 16:16 ` [PATCH for-8.0 v2 1/3] async: Suppress GCC13 false positive in aio_bh_poll() Cédric Le Goater
2023-03-22 7:11 ` Thomas Huth
2023-03-22 8:47 ` Philippe Mathieu-Daudé
2023-03-22 10:21 ` Cédric Le Goater
2023-03-22 13:27 ` Stefan Hajnoczi
2023-03-22 14:42 ` Philippe Mathieu-Daudé
2023-04-18 7:31 ` Marc-André Lureau
2023-04-20 18:43 ` Daniel Henrique Barboza
2023-03-21 16:16 ` [PATCH for-8.0 v2 2/3] target/s390x: Fix float_comp_to_cc() prototype Cédric Le Goater
2023-03-22 3:54 ` Richard Henderson [this message]
2023-03-22 6:52 ` Thomas Huth
2023-03-21 16:16 ` [PATCH for-8.0 v2 3/3] target/ppc: Fix helper_pminsn() prototype Cédric Le Goater
2023-03-22 3:54 ` Richard Henderson
2023-03-22 6:55 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52635c3b-ced1-8310-ece6-b97a7d4a0aad@linaro.org \
--to=richard.henderson@linaro.org \
--cc=clg@kaod.org \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.