From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Bart Van Assche <bvanassche@acm.org>,
Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org,
Bart Van Assche <bart.vanassche@wdc.com>,
Omar Sandoval <osandov@fb.com>,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH 1/2] blk-mq-debugfs: support rq_qos
Date: Sun, 16 Dec 2018 09:13:53 -0700 [thread overview]
Message-ID: <526361e5-2726-bbec-51f4-41fd37ae9c8b@kernel.dk> (raw)
In-Reply-To: <20181216160955.GA9957@lst.de>
On 12/16/18 9:09 AM, Christoph Hellwig wrote:
> On Sun, Dec 16, 2018 at 09:04:37AM -0700, Jens Axboe wrote:
>> It would fit better with the style in that code do to:
>>
>> rqos = q->rq_qos;
>> while (rqos) {
>> ....
>> rqos = rqos->next;
>> }
>
> But that is just a really strangly written for loop to start with..
I think it looks fine, and it's more readable than using a for()
loop for something like this.
> Maybe Bart need to send a cleanup patch for the whole file, especially
> given that this patch has been applied already.
As mentioned in the same thread, I dropped these since I had to
amend a commit anyway. So we're free to do whatever.
--
Jens Axboe
next prev parent reply other threads:[~2018-12-16 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 11:39 [PATCH 0/2] block: support debugfs on rq_qos & wbt Ming Lei
2018-12-14 11:39 ` [PATCH 1/2] blk-mq-debugfs: support rq_qos Ming Lei
2018-12-14 19:11 ` Bart Van Assche
2018-12-16 16:04 ` Jens Axboe
2018-12-16 16:09 ` Christoph Hellwig
2018-12-16 16:13 ` Jens Axboe [this message]
2018-12-14 11:39 ` [PATCH 2/2] blk-wbt: export internal state via debugfs Ming Lei
2018-12-14 19:15 ` Bart Van Assche
2018-12-16 16:07 ` Jens Axboe
2018-12-17 1:10 ` Ming Lei
2018-12-14 12:56 ` [PATCH 0/2] block: support debugfs on rq_qos & wbt Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526361e5-2726-bbec-51f4-41fd37ae9c8b@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.