From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C626C432C3 for ; Fri, 15 Nov 2019 14:31:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5742220733 for ; Fri, 15 Nov 2019 14:31:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573828307; bh=z4t0QNOpMSUfT6xxNqEGeyK4kvswHzvxvuh4u4MxWE4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=1na+qrnm9WqySjStmOqndegddDnxhGUtJ1pxk8LQ/AtWg4z2jgyuaPFzfc+9lxqMK MA5MAaUylaqPe9igPHaRKDso6D2J5tKyl+zs0tvmbQQY0XoCYtyOQ4Cab/xOCAIPEB A3aVNTTOoi3ASruRRbY0rl6aUB49XPKFBLLgc26k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727614AbfKOObq (ORCPT ); Fri, 15 Nov 2019 09:31:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:49082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727380AbfKOObq (ORCPT ); Fri, 15 Nov 2019 09:31:46 -0500 Received: from [192.168.1.20] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABC7D2072D; Fri, 15 Nov 2019 14:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573828305; bh=z4t0QNOpMSUfT6xxNqEGeyK4kvswHzvxvuh4u4MxWE4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=tMCfohkEdQO5MZtypr3lSf1IVaJNmcuvM+seUixNNfXHYT1wU3BcK1Cfe+diLM0eV fyzg3L/GNsHDQ+PhCDP+S6JRz0JMtKXb/fISpdS5IYkDXiRF5RBdamtlBk10zLLTLj TmouuZ3KKjaXi3Y2CWdFcKM2A7/uTmgAkKcO5vH8= Subject: Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32 To: Li Yang Cc: Rasmus Villemoes , Qiang Zhao , Christophe Leroy , linuxppc-dev , linux-arm-kernel , lkml , Scott Wood , netdev References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-47-linux@rasmusvillemoes.dk> From: Timur Tabi Message-ID: <52639dfc-d558-8a92-5e2e-8ec18f39b383@kernel.org> Date: Fri, 15 Nov 2019 08:31:42 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/19 11:44 PM, Li Yang wrote: >> Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? > I think it is because the QE Ethernet was never integrated in any > non-PowerPC SoC and most likely will not be in the future. We > probably can make it compile for other architectures for general code > quality but it is not a priority. This explanation belongs in the commit message. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C78C432C3 for ; Fri, 15 Nov 2019 14:34:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35CD62073B for ; Fri, 15 Nov 2019 14:34:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tMCfohkE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35CD62073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47F17Z6lBjzF5s9 for ; Sat, 16 Nov 2019 01:34:02 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=timur@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="tMCfohkE"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47F1500n1TzF3Jx for ; Sat, 16 Nov 2019 01:31:47 +1100 (AEDT) Received: from [192.168.1.20] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABC7D2072D; Fri, 15 Nov 2019 14:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573828305; bh=z4t0QNOpMSUfT6xxNqEGeyK4kvswHzvxvuh4u4MxWE4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=tMCfohkEdQO5MZtypr3lSf1IVaJNmcuvM+seUixNNfXHYT1wU3BcK1Cfe+diLM0eV fyzg3L/GNsHDQ+PhCDP+S6JRz0JMtKXb/fISpdS5IYkDXiRF5RBdamtlBk10zLLTLj TmouuZ3KKjaXi3Y2CWdFcKM2A7/uTmgAkKcO5vH8= Subject: Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32 To: Li Yang References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-47-linux@rasmusvillemoes.dk> From: Timur Tabi Message-ID: <52639dfc-d558-8a92-5e2e-8ec18f39b383@kernel.org> Date: Fri, 15 Nov 2019 08:31:42 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev , Rasmus Villemoes , lkml , Scott Wood , linuxppc-dev , linux-arm-kernel , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 11/14/19 11:44 PM, Li Yang wrote: >> Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? > I think it is because the QE Ethernet was never integrated in any > non-PowerPC SoC and most likely will not be in the future. We > probably can make it compile for other architectures for general code > quality but it is not a priority. This explanation belongs in the commit message. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3057CC432C3 for ; Fri, 15 Nov 2019 14:32:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F22BF2072D for ; Fri, 15 Nov 2019 14:32:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u6JVZsEP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tMCfohkE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F22BF2072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sb8hsAUZI0NqNAON6MNbOI0GAhybW5cPM3bqOOqxYgw=; b=u6JVZsEPbLZh2OkTu9pEMFcNy KmBd+9WJhcej2nPPi9TRj3ZJ/VC3b7rFpK+IqfXUJr7cCQbGGAF4hEdLq5aQ+MA/WslYYPCEgVbLf WWi6AQDypoF4kJuTdG/bRc3Em25c/u6ZPzDKMnFd5I/dGZo+R27BNNX7uHUZ4uTGUtwx0TawDxVCn ZyOaTH7zIGblsSf0xWMm0IsU3BNomhbr6V6ffJB0CalJlyeckGjSLZNyrRY2gu9OhrVIt9L3ELWG4 9ucvduvWQDbwsCC7hnlyV611E/8km/f1IHnFsSl/M1xl0pMnE2/3dKTLrItYpE3ZFWDsJJRqWdiPr bZg2SIOKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVcda-0002Ga-4u; Fri, 15 Nov 2019 14:31:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVcdW-0002Fd-Dz for linux-arm-kernel@lists.infradead.org; Fri, 15 Nov 2019 14:31:48 +0000 Received: from [192.168.1.20] (cpe-24-28-70-126.austin.res.rr.com [24.28.70.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABC7D2072D; Fri, 15 Nov 2019 14:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573828305; bh=z4t0QNOpMSUfT6xxNqEGeyK4kvswHzvxvuh4u4MxWE4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=tMCfohkEdQO5MZtypr3lSf1IVaJNmcuvM+seUixNNfXHYT1wU3BcK1Cfe+diLM0eV fyzg3L/GNsHDQ+PhCDP+S6JRz0JMtKXb/fISpdS5IYkDXiRF5RBdamtlBk10zLLTLj TmouuZ3KKjaXi3Y2CWdFcKM2A7/uTmgAkKcO5vH8= Subject: Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32 To: Li Yang References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-47-linux@rasmusvillemoes.dk> From: Timur Tabi Message-ID: <52639dfc-d558-8a92-5e2e-8ec18f39b383@kernel.org> Date: Fri, 15 Nov 2019 08:31:42 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191115_063146_494387_8F8E012A X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , netdev , Rasmus Villemoes , lkml , Scott Wood , linuxppc-dev , linux-arm-kernel , Qiang Zhao Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/14/19 11:44 PM, Li Yang wrote: >> Can you add an explanation why we don't want ucc_geth on non-PowerPC platforms? > I think it is because the QE Ethernet was never integrated in any > non-PowerPC SoC and most likely will not be in the future. We > probably can make it compile for other architectures for general code > quality but it is not a priority. This explanation belongs in the commit message. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel