From: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: src/feature.c: print a number of online CPUs
Date: Thu, 24 Oct 2013 18:33:16 +0400 [thread overview]
Message-ID: <52692FAC.8090904@oracle.com> (raw)
In-Reply-To: <20131024131800.GA27701@orion.maiolino.org>
On 10/24/2013 05:18 PM, Carlos Maiolino wrote:
> Hi Dave,
>
> I'm not sure about setting the default to 1 cpu might me a good behavior. My
> apologies if I'm saying something wrong, but, if the 'tester' are trying to do
> some test trusting on the amount of cpus, it might not be a good behavior.
> I was thinking, how about issue an error message if xfstests can't properly
> detect the amount of cpus from the system, and add any kind of usage option to
> specify the numbers of cpus? So in case of a error while detecting the amount of
> cpus.
What about this:
If we can not determine the number of available cpus we just
print '-1' (as sysconf() returns in that case) and exit with non-zero
status.
And verify the exit status in the test cases.
What do you mean by:
"and add any kind of usage option to specify the numbers of cpus"
?
Thanks.
>
>
>> Actually, I'd say we shoul default to 1 cpu if we can't get the
>> number of CPUs. Clearly we have at least one if we can run this
>> code. :)
>>
>> Cheers,
>>
>> Dave.
>> --
>> Dave Chinner
>> david@fromorbit.com
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-24 14:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 11:58 Avoid of using /proc/cpuinfo in generic tests Stanislav Kholmanskikh
2013-10-23 11:58 ` [PATCH 1/2] xfstests: implemented _no_of_online_cpus() function Stanislav Kholmanskikh
2013-10-23 13:08 ` Carlos Maiolino
2013-10-23 21:31 ` Dave Chinner
2013-10-24 8:56 ` [PATCH] xfstests: src/feature.c: print a number of online CPUs Stanislav Kholmanskikh
2013-10-24 10:40 ` Dave Chinner
2013-10-24 12:10 ` [PATCH V2] " Stanislav Kholmanskikh
2013-10-28 22:15 ` Dave Chinner
2013-10-29 10:03 ` [PATCH V3] " Stanislav Kholmanskikh
2013-11-05 12:41 ` Stanislav Kholmanskikh
2013-11-10 1:19 ` Rich Johnston
2013-11-10 1:20 ` Rich Johnston
2013-10-24 13:18 ` [PATCH] " Carlos Maiolino
2013-10-24 14:33 ` Stanislav Kholmanskikh [this message]
2013-10-24 21:23 ` Dave Chinner
2013-10-28 7:23 ` Stanislav Kholmanskikh
2013-10-28 12:23 ` Carlos Maiolino
2013-10-23 11:58 ` [PATCH 2/2] xfstests: generic/273: do not use /proc/cpuinfo Stanislav Kholmanskikh
2013-10-23 13:09 ` Carlos Maiolino
2013-10-24 0:14 ` Rich Johnston
2013-10-24 1:09 ` Dave Chinner
2013-11-11 9:34 ` [PATCH] xfstests: generic/273: use src/feature -o Stanislav Kholmanskikh
2013-11-11 11:10 ` Jeff Liu
2013-11-11 16:05 ` Rich Johnston
2013-11-11 16:06 ` Rich Johnston
2013-11-11 14:50 ` [PATCH 2/2] xfstests: generic/273: do not use /proc/cpuinfo Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52692FAC.8090904@oracle.com \
--to=stanislav.kholmanskikh@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.