From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZqGB-0006cx-6E for qemu-devel@nongnu.org; Fri, 25 Oct 2013 18:53:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZqG2-0007sD-Oo for qemu-devel@nongnu.org; Fri, 25 Oct 2013 18:53:39 -0400 Received: from mail-we0-x234.google.com ([2a00:1450:400c:c03::234]:59423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZqG2-0007s8-I1 for qemu-devel@nongnu.org; Fri, 25 Oct 2013 18:53:30 -0400 Received: by mail-we0-f180.google.com with SMTP id q59so4386171wes.25 for ; Fri, 25 Oct 2013 15:53:29 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <526AF64E.6040404@redhat.com> Date: Fri, 25 Oct 2013 23:53:02 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20131024211158.064049176@amt.cnet> <20131024211249.723543071@amt.cnet> <5269B378.6040409@redhat.com> <20131025045805.GA18280@amt.cnet> <526A3152.2020603@redhat.com> <20131025195032.GA6391@amt.cnet> In-Reply-To: <20131025195032.GA6391@amt.cnet> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [patch 2/2] i386: pc: align gpa<->hpa on 1GB boundary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti Cc: aarcange@redhat.com, qemu-devel@nongnu.org, gleb@redhat.com, "Michael S. Tsirkin" Il 25/10/2013 20:50, Marcelo Tosatti ha scritto: > On Fri, Oct 25, 2013 at 09:52:34AM +0100, Paolo Bonzini wrote: >> Because offsets are zero, and lengths match the RAM block lengths, you >> do not need any complication with aliasing. This still has to be done >> only for new machine types. > > Not possible because you just wasted holesize bytes (if number of > additional bytes due to huge page alignment is smaller than holesize, a > new hugepage is required, which is not acceptable). Ok. Thanks for explaining---the patch seems good with the proper compatibility option in the machine type. Please run the guest_memory_dump_analysis test in autotest too. > Is there a tree the new machine types can live until 1.8 opens up? > > Can you pick up the MAP_POPULATE patch? Yes, I can pick that one up next week. Michael is usually gathering hw/i386/pc* patches in his PCI tree, you can Cc him on v2 of this one. Paolo