From: Vineet Gupta <vineetg76@gmail.com>
To: Chen Gang <gang.chen@asianux.com>
Cc: James Hogan <james.hogan@imgtec.com>,
Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH v2] arch: use ASM_NL instead of ';' for assembler new line character in the macro
Date: Tue, 29 Oct 2013 11:25:27 +0530 [thread overview]
Message-ID: <526F4DCF.5010406@synopsys.com> (raw)
In-Reply-To: <526F149A.3000306@asianux.com>
On 10/29/2013 07:21 AM, Chen Gang wrote:
> For some assemblers, they use another character as newline in a macro
> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a
> macro) instead of ';' for it.
>
> Also need notice about code styles ('\t' for each line).
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arc/include/asm/linkage.h | 2 ++
> include/linux/linkage.h | 19 ++++++++++++-------
Acked-by: Vineet Gupta <vgupta@synopsys.com>
-Vineet
next prev parent reply other threads:[~2013-10-29 5:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 10:30 [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro Chen Gang
2013-10-28 11:18 ` Max Filippov
2013-10-29 7:57 ` Chen Gang
2013-10-29 8:34 ` Max Filippov
2013-10-29 8:47 ` Chen Gang
2013-10-28 13:45 ` Vineet Gupta
2013-10-29 1:04 ` Chen Gang
2013-10-29 1:39 ` Chen Gang
2013-10-29 1:51 ` [PATCH v2] " Chen Gang
2013-10-29 5:55 ` Vineet Gupta [this message]
2013-10-29 6:07 ` Chen Gang
2013-11-01 5:45 ` Vineet Gupta
2013-11-21 9:58 ` Vineet Gupta
2013-11-21 10:52 ` Chen Gang
2014-01-03 12:38 ` Michal Marek
2014-01-06 5:36 ` Vineet Gupta
2014-01-06 9:26 ` Michal Marek
2014-01-09 6:41 ` Vineet Gupta
2014-01-10 15:48 ` Chen Gang
2014-01-12 1:59 ` [PATCH v3] " Chen Gang
2014-01-18 9:44 ` Chen Gang
2014-01-21 4:55 ` Vineet Gupta
2014-01-25 11:07 ` Chen Gang
2014-01-27 21:57 ` Michal Marek
2014-01-30 5:41 ` Chen Gang
2013-10-29 10:39 ` [PATCH] " David Howells
2013-10-29 11:53 ` Chen Gang
2013-10-29 13:59 ` David Howells
2013-10-30 0:57 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526F4DCF.5010406@synopsys.com \
--to=vineetg76@gmail.com \
--cc=arnd@arndb.de \
--cc=gang.chen@asianux.com \
--cc=james.hogan@imgtec.com \
--cc=jcmvbkbc@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.