From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shimoda, Yoshihiro" Date: Tue, 29 Oct 2013 09:47:19 +0000 Subject: Re: [PATCH 09/12] usb: gadget: r8a66597-udc: Convert to clk_prepare/unprepare Message-Id: <526F8427.8000209@renesas.com> List-Id: References: <1383000569-8916-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1383000569-8916-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1383000569-8916-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hi Laurent-san, (2013/10/29 7:49), Laurent Pinchart wrote: > Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and > clk_disable_unprepare() to get ready for the migration to the common > clock framework. > > Cc: Felipe Balbi > Cc: linux-usb@vger.kernel.org > Signed-off-by: Laurent Pinchart Thank you for the patch. Acked-by: Yoshihiro Shimoda Best regards, Yoshihro Shimoda > --- > drivers/usb/gadget/r8a66597-udc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c > index 68be48d..4728751 100644 > --- a/drivers/usb/gadget/r8a66597-udc.c > +++ b/drivers/usb/gadget/r8a66597-udc.c > @@ -1833,7 +1833,7 @@ static int __exit r8a66597_remove(struct platform_device *pdev) > r8a66597_free_request(&r8a66597->ep[0].ep, r8a66597->ep0_req); > > if (r8a66597->pdata->on_chip) { > - clk_disable(r8a66597->clk); > + clk_disable_unprepare(r8a66597->clk); > clk_put(r8a66597->clk); > } > > @@ -1931,7 +1931,7 @@ static int __init r8a66597_probe(struct platform_device *pdev) > ret = PTR_ERR(r8a66597->clk); > goto clean_up; > } > - clk_enable(r8a66597->clk); > + clk_prepare_enable(r8a66597->clk); > } > > if (r8a66597->pdata->sudmac) { > @@ -1996,7 +1996,7 @@ clean_up3: > free_irq(irq, r8a66597); > clean_up2: > if (r8a66597->pdata->on_chip) { > - clk_disable(r8a66597->clk); > + clk_disable_unprepare(r8a66597->clk); > clk_put(r8a66597->clk); > } > clean_up: > -- Yoshihiro Shimoda EC No. From mboxrd@z Thu Jan 1 00:00:00 1970 From: yoshihiro.shimoda.uh@renesas.com (Shimoda, Yoshihiro) Date: Tue, 29 Oct 2013 18:47:19 +0900 Subject: [PATCH 09/12] usb: gadget: r8a66597-udc: Convert to clk_prepare/unprepare In-Reply-To: <1383000569-8916-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com> References: <1383000569-8916-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1383000569-8916-10-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Message-ID: <526F8427.8000209@renesas.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Laurent-san, (2013/10/29 7:49), Laurent Pinchart wrote: > Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and > clk_disable_unprepare() to get ready for the migration to the common > clock framework. > > Cc: Felipe Balbi > Cc: linux-usb at vger.kernel.org > Signed-off-by: Laurent Pinchart Thank you for the patch. Acked-by: Yoshihiro Shimoda Best regards, Yoshihro Shimoda > --- > drivers/usb/gadget/r8a66597-udc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c > index 68be48d..4728751 100644 > --- a/drivers/usb/gadget/r8a66597-udc.c > +++ b/drivers/usb/gadget/r8a66597-udc.c > @@ -1833,7 +1833,7 @@ static int __exit r8a66597_remove(struct platform_device *pdev) > r8a66597_free_request(&r8a66597->ep[0].ep, r8a66597->ep0_req); > > if (r8a66597->pdata->on_chip) { > - clk_disable(r8a66597->clk); > + clk_disable_unprepare(r8a66597->clk); > clk_put(r8a66597->clk); > } > > @@ -1931,7 +1931,7 @@ static int __init r8a66597_probe(struct platform_device *pdev) > ret = PTR_ERR(r8a66597->clk); > goto clean_up; > } > - clk_enable(r8a66597->clk); > + clk_prepare_enable(r8a66597->clk); > } > > if (r8a66597->pdata->sudmac) { > @@ -1996,7 +1996,7 @@ clean_up3: > free_irq(irq, r8a66597); > clean_up2: > if (r8a66597->pdata->on_chip) { > - clk_disable(r8a66597->clk); > + clk_disable_unprepare(r8a66597->clk); > clk_put(r8a66597->clk); > } > clean_up: > -- Yoshihiro Shimoda EC No.