From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755639Ab3J2NvI (ORCPT ); Tue, 29 Oct 2013 09:51:08 -0400 Received: from 13.mo6.mail-out.ovh.net ([188.165.56.124]:58055 "EHLO mo6.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752594Ab3J2NvG (ORCPT ); Tue, 29 Oct 2013 09:51:06 -0400 Message-ID: <526FB752.7070708@overkiz.com> Date: Tue, 29 Oct 2013 14:25:38 +0100 From: boris brezillon User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Wim Van Sebroeck CC: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Russell King , Fabio Porcedda , Nicolas Ferre , Guenter Roeck , Yang Wenyou , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH v5 0/4] watchdog: at91sam9_wdt: handle already configured wdt References: <1380871455-7324-1-git-send-email-b.brezillon@overkiz.com> <20131029075028.GF19704@spo001.leaseweb.com> <526F8E89.30005@overkiz.com> <20131029125848.GB5261@spo001.leaseweb.com> In-Reply-To: <20131029125848.GB5261@spo001.leaseweb.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 13198924608119601336 X-Ovh-Remote: 80.245.18.66 () X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeiledrgeeiucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd X-Spam-Check: DONE|U 0.5/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeiledrgeeiucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/10/2013 13:58, Wim Van Sebroeck wrote: > Hi Boris, > >> I'm sorry for the inconvenience, but I found some bugs in my patch series: >> >> 1) the secs_to_ticks returns an erronous value when 0 is passed as an >> argument >> 2) the calculated heartbeat is too small for some use cases >> (i.e. kexecing a new kernel might trigger a watchdog reset before >> the new kernel >> is able to load the watchdog driver) >> 3) when initializing the watchdog driver, the timer should be configured >> with the min_heartbeat value >> instead of the standard heartbeat value, because we don't for how >> long the timer has been running. >> >> I'll send a new patch fixing those issues. >> I hope it won't bother you :-(. > No problem :-). Just sent me the fixes when they are ready. Already done : https://lkml.org/lkml/2013/10/29/207. Thanks. Best Regards, Boris > > Kind regards, > Wim. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: b.brezillon@overkiz.com (boris brezillon) Date: Tue, 29 Oct 2013 14:25:38 +0100 Subject: [PATCH v5 0/4] watchdog: at91sam9_wdt: handle already configured wdt In-Reply-To: <20131029125848.GB5261@spo001.leaseweb.com> References: <1380871455-7324-1-git-send-email-b.brezillon@overkiz.com> <20131029075028.GF19704@spo001.leaseweb.com> <526F8E89.30005@overkiz.com> <20131029125848.GB5261@spo001.leaseweb.com> Message-ID: <526FB752.7070708@overkiz.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 29/10/2013 13:58, Wim Van Sebroeck wrote: > Hi Boris, > >> I'm sorry for the inconvenience, but I found some bugs in my patch series: >> >> 1) the secs_to_ticks returns an erronous value when 0 is passed as an >> argument >> 2) the calculated heartbeat is too small for some use cases >> (i.e. kexecing a new kernel might trigger a watchdog reset before >> the new kernel >> is able to load the watchdog driver) >> 3) when initializing the watchdog driver, the timer should be configured >> with the min_heartbeat value >> instead of the standard heartbeat value, because we don't for how >> long the timer has been running. >> >> I'll send a new patch fixing those issues. >> I hope it won't bother you :-(. > No problem :-). Just sent me the fixes when they are ready. Already done : https://lkml.org/lkml/2013/10/29/207. Thanks. Best Regards, Boris > > Kind regards, > Wim. >