From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21EA9C433EF for ; Sun, 10 Jul 2022 15:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229633AbiGJP6T (ORCPT ); Sun, 10 Jul 2022 11:58:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbiGJP6S (ORCPT ); Sun, 10 Jul 2022 11:58:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8534612A9A for ; Sun, 10 Jul 2022 08:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657468696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hcSBWuPanw+MSnwNJ3oSObjsYDtvUnp4dMZLTgyW6kg=; b=IOGWYmD9IqUtAGXw3hzzpMwVJbprbjV6IMchf/28UgX2x4RPzj/qXL7jCHIvtyeTWFi9K6 XFO9cr93QX0VTRH7h3L9yV00/GBZPzLFNYRxLj8A7WEYhggCGniCSdEcihKpfgDvt/l1qe 09H/COP6T5KNC5yAe74dMVutklFTwfI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-550-hfGJnngzN6Cz-QVcSiGrKg-1; Sun, 10 Jul 2022 11:58:11 -0400 X-MC-Unique: hfGJnngzN6Cz-QVcSiGrKg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED8772A59547; Sun, 10 Jul 2022 15:58:10 +0000 (UTC) Received: from starship (unknown [10.40.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7413D2026D64; Sun, 10 Jul 2022 15:58:08 +0000 (UTC) Message-ID: <527713984b43e372e569209f394c54520d3b3e60.camel@redhat.com> Subject: Re: [PATCH v2 00/21] KVM: x86: Event/exception fixes and cleanups From: Maxim Levitsky To: Jim Mattson , Sean Christopherson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Upton , Peter Shier Date: Sun, 10 Jul 2022 18:58:07 +0300 In-Reply-To: References: <20220614204730.3359543-1-seanjc@google.com> <7e05e0befa13af05f1e5f0fd8658bc4e7bdf764f.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-07-06 at 13:11 -0700, Jim Mattson wrote: > On Wed, Jul 6, 2022 at 10:52 AM Sean Christopherson wrote: > > > Hmm, I'm not entirely convinced that Intel doesn't interpret "internal to the > > processor" as "undocumented SMRAM fields". But I could also be misremembering > > the SMI flows. > > Start using reserved SMRAM, and you will regret it when the vendor > assigns some new bit of state to the same location. > This is true to some extent, but our SMRAM layout doesn't follow the spec anyway. This is the reason I asked (I posted an RFC as a good citizen), in the first place all of you, if you prefer SMRAM or KVM internal state. Anyway if this is a concern, I can just save the interrupt shadow in KVM, and migrate it, its not hard, in fact the v1 of my patches did exactly that. Paolo, what should I do? Best regards, Maxim Levitsky