From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754786Ab3KEQEJ (ORCPT ); Tue, 5 Nov 2013 11:04:09 -0500 Received: from mail-qc0-f169.google.com ([209.85.216.169]:50687 "EHLO mail-qc0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263Ab3KEQEH (ORCPT ); Tue, 5 Nov 2013 11:04:07 -0500 Message-ID: <527916F4.1010805@linaro.org> Date: Tue, 05 Nov 2013 11:04:04 -0500 From: David Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Oleg Nesterov CC: linux-arm-kernel@lists.infradead.org, Rabin Vincent , "Jon Medhurst (Tixy)" , Srikar Dronamraju , Ingo Molnar , linux-kernel@vger.kernel.org, Ananth N Mavinakayanahalli Subject: Re: [PATCH] uprobes: introduce arch_uprobe->ixol References: <1381871068-27660-1-git-send-email-dave.long@linaro.org> <1381871068-27660-4-git-send-email-dave.long@linaro.org> <20131019163627.GA7837@redhat.com> <52671265.2020107@linaro.org> <20131029154006.GA22344@redhat.com> <20131104194901.GA28022@redhat.com> In-Reply-To: <20131104194901.GA28022@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/13 14:49, Oleg Nesterov wrote: > On 10/29, Oleg Nesterov wrote: >> >> David. Perhaps we can avoid the new hook altogether? What if we do >> the simple change below (it ignores powerpc) ? >> >> Then arm can add "unsigned long ixol[2]" into its arch_uprobe, and >> arch_uprobe_analyze_insn() can initialize this member correctly. >> >> What do you think? > > Seriouly, how about the patch below? > > In fact, given that you are going to reimplement set_swbp/orig_insn, > the new member is not strictly needed (afaics). But it looks more > clear this way, and we need s/MAX_UINSN_BYTES/sizeof()/ anyway. > > Oleg. > --- I agree that this is cleaner than another weak callout. I have it working for ARM now. Thanks, -dl From mboxrd@z Thu Jan 1 00:00:00 1970 From: dave.long@linaro.org (David Long) Date: Tue, 05 Nov 2013 11:04:04 -0500 Subject: [PATCH] uprobes: introduce arch_uprobe->ixol In-Reply-To: <20131104194901.GA28022@redhat.com> References: <1381871068-27660-1-git-send-email-dave.long@linaro.org> <1381871068-27660-4-git-send-email-dave.long@linaro.org> <20131019163627.GA7837@redhat.com> <52671265.2020107@linaro.org> <20131029154006.GA22344@redhat.com> <20131104194901.GA28022@redhat.com> Message-ID: <527916F4.1010805@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/04/13 14:49, Oleg Nesterov wrote: > On 10/29, Oleg Nesterov wrote: >> >> David. Perhaps we can avoid the new hook altogether? What if we do >> the simple change below (it ignores powerpc) ? >> >> Then arm can add "unsigned long ixol[2]" into its arch_uprobe, and >> arch_uprobe_analyze_insn() can initialize this member correctly. >> >> What do you think? > > Seriouly, how about the patch below? > > In fact, given that you are going to reimplement set_swbp/orig_insn, > the new member is not strictly needed (afaics). But it looks more > clear this way, and we need s/MAX_UINSN_BYTES/sizeof()/ anyway. > > Oleg. > --- I agree that this is cleaner than another weak callout. I have it working for ARM now. Thanks, -dl