From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Date: Fri, 08 Nov 2013 10:10:23 +0000 Subject: Re: [PATCH v2 2/2] clocksource: sh_mtu2: Add clk_prepare/unprepare support Message-Id: <527CB88F.1060107@linaro.org> List-Id: References: <1383000569-8916-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1383057045-22608-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1383057045-22608-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1383057045-22608-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org On 10/29/2013 03:30 PM, Laurent Pinchart wrote: > Prepare the clock at probe time, as there is no other appropriate place > in the driver where we're allowed to sleep. > > Cc: Daniel Lezcano > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Laurent Pinchart Applied in my tree as 3.13 fixes > --- > drivers/clocksource/sh_mtu2.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c > index e6cfb32..3cf1283 100644 > --- a/drivers/clocksource/sh_mtu2.c > +++ b/drivers/clocksource/sh_mtu2.c > @@ -313,13 +313,18 @@ static int sh_mtu2_setup(struct sh_mtu2_priv *p, st= ruct platform_device *pdev) > goto err1; > } > > + ret =3D clk_prepare(p->clk); > + if (ret < 0) > + goto err2; > + > ret =3D sh_mtu2_register(p, (char *)dev_name(&p->pdev->dev), > cfg->clockevent_rating); > if (ret < 0) > - goto err2; > + goto err3; > > return 0; > - > + err3: > + clk_unprepare(p->clk); > err2: > clk_put(p->clk); > err1: > --=20 Linaro.org =E2=94=82 Open source software for AR= M SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757011Ab3KHKKb (ORCPT ); Fri, 8 Nov 2013 05:10:31 -0500 Received: from mail-ea0-f174.google.com ([209.85.215.174]:56350 "EHLO mail-ea0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756972Ab3KHKK0 (ORCPT ); Fri, 8 Nov 2013 05:10:26 -0500 Message-ID: <527CB88F.1060107@linaro.org> Date: Fri, 08 Nov 2013 11:10:23 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Laurent Pinchart , linux-arm-kernel@lists.infradead.org CC: linux-sh@vger.kernel.org, Mike Turquette , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] clocksource: sh_mtu2: Add clk_prepare/unprepare support References: <1383000569-8916-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1383057045-22608-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1383057045-22608-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1383057045-22608-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29/2013 03:30 PM, Laurent Pinchart wrote: > Prepare the clock at probe time, as there is no other appropriate place > in the driver where we're allowed to sleep. > > Cc: Daniel Lezcano > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Laurent Pinchart Applied in my tree as 3.13 fixes > --- > drivers/clocksource/sh_mtu2.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c > index e6cfb32..3cf1283 100644 > --- a/drivers/clocksource/sh_mtu2.c > +++ b/drivers/clocksource/sh_mtu2.c > @@ -313,13 +313,18 @@ static int sh_mtu2_setup(struct sh_mtu2_priv *p, struct platform_device *pdev) > goto err1; > } > > + ret = clk_prepare(p->clk); > + if (ret < 0) > + goto err2; > + > ret = sh_mtu2_register(p, (char *)dev_name(&p->pdev->dev), > cfg->clockevent_rating); > if (ret < 0) > - goto err2; > + goto err3; > > return 0; > - > + err3: > + clk_unprepare(p->clk); > err2: > clk_put(p->clk); > err1: > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Fri, 08 Nov 2013 11:10:23 +0100 Subject: [PATCH v2 2/2] clocksource: sh_mtu2: Add clk_prepare/unprepare support In-Reply-To: <1383057045-22608-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> References: <1383000569-8916-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1383057045-22608-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1383057045-22608-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Message-ID: <527CB88F.1060107@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/29/2013 03:30 PM, Laurent Pinchart wrote: > Prepare the clock at probe time, as there is no other appropriate place > in the driver where we're allowed to sleep. > > Cc: Daniel Lezcano > Cc: linux-kernel at vger.kernel.org > Signed-off-by: Laurent Pinchart Applied in my tree as 3.13 fixes > --- > drivers/clocksource/sh_mtu2.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c > index e6cfb32..3cf1283 100644 > --- a/drivers/clocksource/sh_mtu2.c > +++ b/drivers/clocksource/sh_mtu2.c > @@ -313,13 +313,18 @@ static int sh_mtu2_setup(struct sh_mtu2_priv *p, struct platform_device *pdev) > goto err1; > } > > + ret = clk_prepare(p->clk); > + if (ret < 0) > + goto err2; > + > ret = sh_mtu2_register(p, (char *)dev_name(&p->pdev->dev), > cfg->clockevent_rating); > if (ret < 0) > - goto err2; > + goto err3; > > return 0; > - > + err3: > + clk_unprepare(p->clk); > err2: > clk_put(p->clk); > err1: > -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog