From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752247Ab3KKCW7 (ORCPT ); Sun, 10 Nov 2013 21:22:59 -0500 Received: from terminus.zytor.com ([198.137.202.10]:35458 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016Ab3KKCWu (ORCPT ); Sun, 10 Nov 2013 21:22:50 -0500 Message-ID: <52803F15.3080204@zytor.com> Date: Sun, 10 Nov 2013 18:21:09 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Dave Young CC: Matt Fleming , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org, James.Bottomley@HansenPartnership.com, vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au, kexec@lists.infradead.org, bp@alien8.de, Greg KH Subject: Re: [patch 0/7 v2] kexec kernel efi runtime support References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131108143118.GA22636@console-pimps.org> <20131109035739.GB4294@dhcp-16-126.nay.redhat.com> <527DC1BE.6030107@zytor.com> <20131111021356.GC4407@dhcp-16-126.nay.redhat.com> In-Reply-To: <20131111021356.GC4407@dhcp-16-126.nay.redhat.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/2013 06:13 PM, Dave Young wrote: > > Huang Ying created the debugfs file for boot_params. > His first version patch tried sysfs, but sysfs is not designed for such > binary blobs so finally it go to debugfs. > That is a misunderstanding. Binary blobs can exist in sysfs as long as the blob is something that is inherently a blob. This is admittedly a corner case, but it is without any doubt a protocol-defined binary structure. The reason it was put in debugfs is that there was no non-debug user for it at the time. > Any idea for this is welcome, till now I have no better idea for such kind > of data. We should have another *fs instead of using debugfs. The problem with debugfs is that things go into debugfs with largely no auditing. As a result, mounting debugfs is very likely to mean that your system is exploitable one way or another. -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [patch 0/7 v2] kexec kernel efi runtime support Date: Sun, 10 Nov 2013 18:21:09 -0800 Message-ID: <52803F15.3080204@zytor.com> References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131108143118.GA22636@console-pimps.org> <20131109035739.GB4294@dhcp-16-126.nay.redhat.com> <527DC1BE.6030107@zytor.com> <20131111021356.GC4407@dhcp-16-126.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131111021356.GC4407-je1gSBvt1TcFLmT5oZ11vB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "kexec" Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Dave Young Cc: Matt Fleming , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org, Greg KH , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org, horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-efi@vger.kernel.org On 11/10/2013 06:13 PM, Dave Young wrote: > > Huang Ying created the debugfs file for boot_params. > His first version patch tried sysfs, but sysfs is not designed for such > binary blobs so finally it go to debugfs. > That is a misunderstanding. Binary blobs can exist in sysfs as long as the blob is something that is inherently a blob. This is admittedly a corner case, but it is without any doubt a protocol-defined binary structure. The reason it was put in debugfs is that there was no non-debug user for it at the time. > Any idea for this is welcome, till now I have no better idea for such kind > of data. We should have another *fs instead of using debugfs. The problem with debugfs is that things go into debugfs with largely no auditing. As a result, mounting debugfs is very likely to mean that your system is exploitable one way or another. -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from terminus.zytor.com ([2001:1868:205::10] helo=mail.zytor.com) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vfh93-0002xj-8C for kexec@lists.infradead.org; Mon, 11 Nov 2013 02:22:30 +0000 Message-ID: <52803F15.3080204@zytor.com> Date: Sun, 10 Nov 2013 18:21:09 -0800 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [patch 0/7 v2] kexec kernel efi runtime support References: <20131105082007.872550445@dhcp-16-126.nay.redhat.com> <20131108143118.GA22636@console-pimps.org> <20131109035739.GB4294@dhcp-16-126.nay.redhat.com> <527DC1BE.6030107@zytor.com> <20131111021356.GC4407@dhcp-16-126.nay.redhat.com> In-Reply-To: <20131111021356.GC4407@dhcp-16-126.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=twosheds.infradead.org@lists.infradead.org To: Dave Young Cc: Matt Fleming , linux-efi@vger.kernel.org, mjg59@srcf.ucam.org, Greg KH , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com, horms@verge.net.au, bp@alien8.de, ebiederm@xmission.com, vgoyal@redhat.com On 11/10/2013 06:13 PM, Dave Young wrote: > > Huang Ying created the debugfs file for boot_params. > His first version patch tried sysfs, but sysfs is not designed for such > binary blobs so finally it go to debugfs. > That is a misunderstanding. Binary blobs can exist in sysfs as long as the blob is something that is inherently a blob. This is admittedly a corner case, but it is without any doubt a protocol-defined binary structure. The reason it was put in debugfs is that there was no non-debug user for it at the time. > Any idea for this is welcome, till now I have no better idea for such kind > of data. We should have another *fs instead of using debugfs. The problem with debugfs is that things go into debugfs with largely no auditing. As a result, mounting debugfs is very likely to mean that your system is exploitable one way or another. -hpa _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec