From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6009C433DB for ; Tue, 16 Mar 2021 08:08:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DCA164F71 for ; Tue, 16 Mar 2021 08:08:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DCA164F71 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lM4kP-0006oB-81 for qemu-devel@archiver.kernel.org; Tue, 16 Mar 2021 04:08:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37956) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lM4jm-0006Nd-3a for qemu-devel@nongnu.org; Tue, 16 Mar 2021 04:07:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:21675) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lM4jj-0004dI-S9 for qemu-devel@nongnu.org; Tue, 16 Mar 2021 04:07:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615882050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PN9y6XoBUNKBPG2escDAHz1LZLsNGtzXcJhXkRDovUk=; b=RyX06sOiFckqS2uKjOGk7UV0qL4XVu9hsqOl+/dZEe+gXoe8sSmTOdFRS7ZnBGSYwhfCHP 4S7elgNXfAWWfe8diS1vu/52WqL0Jb4UQFD8IZHqeRFQIEYjLlW5NH85gSybp7pTRRcXrz OwanZtgsJw8Wje7+GtLTCKVSYzlJShs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-zKz-XwnVOwGyCVtsR-W68g-1; Tue, 16 Mar 2021 04:07:27 -0400 X-MC-Unique: zKz-XwnVOwGyCVtsR-W68g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3EABE814315; Tue, 16 Mar 2021 08:07:25 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-12-216.pek2.redhat.com [10.72.12.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1249B62A1B; Tue, 16 Mar 2021 08:07:16 +0000 (UTC) Subject: Re: [RFC v2 12/13] vhost: Check for device VRING_USED_F_NO_NOTIFY at shadow virtqueue kick To: =?UTF-8?Q?Eugenio_P=c3=a9rez?= , qemu-devel@nongnu.org References: <20210315194842.277740-1-eperezma@redhat.com> <20210315194842.277740-13-eperezma@redhat.com> From: Jason Wang Message-ID: <52806611-8435-f80a-63b4-51cfc7a9ead2@redhat.com> Date: Tue, 16 Mar 2021 16:07:15 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210315194842.277740-13-eperezma@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Parav Pandit , "Michael S. Tsirkin" , Guru Prasad , Juan Quintela , Markus Armbruster , virtualization@lists.linux-foundation.org, Harpreet Singh Anand , Xiao W Wang , Eli Cohen , Stefano Garzarella , Michael Lilja , Jim Harford , Rob Miller Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2021/3/16 上午3:48, Eugenio Pérez 写道: > Signed-off-by: Eugenio Pérez > --- > hw/virtio/vhost-shadow-virtqueue.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost-shadow-virtqueue.c b/hw/virtio/vhost-shadow-virtqueue.c > index 68ed0f2740..7df98fc43f 100644 > --- a/hw/virtio/vhost-shadow-virtqueue.c > +++ b/hw/virtio/vhost-shadow-virtqueue.c > @@ -145,6 +145,15 @@ static void vhost_shadow_vq_add(VhostShadowVirtqueue *svq, > svq->ring_id_maps[qemu_head] = elem; > } > > +static void vhost_shadow_vq_kick(VhostShadowVirtqueue *svq) > +{ > + /* Make sure we are reading updated device flag */ > + smp_rmb(); smp_mb() actually? Or it's better to explain this following read needs to be orderd with what read before. Thanks > + if (!(svq->vring.used->flags & VRING_USED_F_NO_NOTIFY)) { > + event_notifier_set(&svq->kick_notifier); > + } > +} > + > /* Handle guest->device notifications */ > static void vhost_handle_guest_kick(EventNotifier *n) > { > @@ -174,7 +183,7 @@ static void vhost_handle_guest_kick(EventNotifier *n) > } > > vhost_shadow_vq_add(svq, elem); > - event_notifier_set(&svq->kick_notifier); > + vhost_shadow_vq_kick(svq); > } > > virtio_queue_set_notification(svq->vq, true); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8C0C433DB for ; Tue, 16 Mar 2021 08:07:34 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACE7D64F71 for ; Tue, 16 Mar 2021 08:07:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACE7D64F71 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 59CF9837D2; Tue, 16 Mar 2021 08:07:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yw7FHfKDOBdG; Tue, 16 Mar 2021 08:07:32 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTP id 0F03B8354D; Tue, 16 Mar 2021 08:07:32 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id DD6FEC000B; Tue, 16 Mar 2021 08:07:31 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6E22BC000A for ; Tue, 16 Mar 2021 08:07:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5411383760 for ; Tue, 16 Mar 2021 08:07:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AI48Tcs-XyaU for ; Tue, 16 Mar 2021 08:07:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9FFEB8354D for ; Tue, 16 Mar 2021 08:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615882048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PN9y6XoBUNKBPG2escDAHz1LZLsNGtzXcJhXkRDovUk=; b=Z4NuH9TOB/HeQyhXUcvZSC9nOWF5EPk6XrNg+ZfKGVBK6fDb6WLgGAQDyvb/+8PxAOpVqx ME0xdmkiwanPy9McU4FA6TFP8VQK3NI4Wep8sCgZphTXSK+Mm6kAaU7BNzOvPNAWWBKWy1 gcz9HSAam9adz9m+/nNh/Akc/f2d9iE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-zKz-XwnVOwGyCVtsR-W68g-1; Tue, 16 Mar 2021 04:07:27 -0400 X-MC-Unique: zKz-XwnVOwGyCVtsR-W68g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3EABE814315; Tue, 16 Mar 2021 08:07:25 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-12-216.pek2.redhat.com [10.72.12.216]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1249B62A1B; Tue, 16 Mar 2021 08:07:16 +0000 (UTC) Subject: Re: [RFC v2 12/13] vhost: Check for device VRING_USED_F_NO_NOTIFY at shadow virtqueue kick To: =?UTF-8?Q?Eugenio_P=c3=a9rez?= , qemu-devel@nongnu.org References: <20210315194842.277740-1-eperezma@redhat.com> <20210315194842.277740-13-eperezma@redhat.com> From: Jason Wang Message-ID: <52806611-8435-f80a-63b4-51cfc7a9ead2@redhat.com> Date: Tue, 16 Mar 2021 16:07:15 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210315194842.277740-13-eperezma@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: Parav Pandit , "Michael S. Tsirkin" , Guru Prasad , virtualization@lists.linux-foundation.org, Harpreet Singh Anand , Xiao W Wang , Eli Cohen , Eric Blake , Michael Lilja , Jim Harford , Rob Miller X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CuWcqCAyMDIxLzMvMTYg5LiK5Y2IMzo0OCwgRXVnZW5pbyBQw6lyZXog5YaZ6YGTOgo+IFNpZ25l ZC1vZmYtYnk6IEV1Z2VuaW8gUMOpcmV6IDxlcGVyZXptYUByZWRoYXQuY29tPgo+IC0tLQo+ICAg aHcvdmlydGlvL3Zob3N0LXNoYWRvdy12aXJ0cXVldWUuYyB8IDExICsrKysrKysrKystCj4gICAx IGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAt LWdpdCBhL2h3L3ZpcnRpby92aG9zdC1zaGFkb3ctdmlydHF1ZXVlLmMgYi9ody92aXJ0aW8vdmhv c3Qtc2hhZG93LXZpcnRxdWV1ZS5jCj4gaW5kZXggNjhlZDBmMjc0MC4uN2RmOThmYzQzZiAxMDA2 NDQKPiAtLS0gYS9ody92aXJ0aW8vdmhvc3Qtc2hhZG93LXZpcnRxdWV1ZS5jCj4gKysrIGIvaHcv dmlydGlvL3Zob3N0LXNoYWRvdy12aXJ0cXVldWUuYwo+IEBAIC0xNDUsNiArMTQ1LDE1IEBAIHN0 YXRpYyB2b2lkIHZob3N0X3NoYWRvd192cV9hZGQoVmhvc3RTaGFkb3dWaXJ0cXVldWUgKnN2cSwK PiAgICAgICBzdnEtPnJpbmdfaWRfbWFwc1txZW11X2hlYWRdID0gZWxlbTsKPiAgIH0KPiAgIAo+ ICtzdGF0aWMgdm9pZCB2aG9zdF9zaGFkb3dfdnFfa2ljayhWaG9zdFNoYWRvd1ZpcnRxdWV1ZSAq c3ZxKQo+ICt7Cj4gKyAgICAvKiBNYWtlIHN1cmUgd2UgYXJlIHJlYWRpbmcgdXBkYXRlZCBkZXZp Y2UgZmxhZyAqLwo+ICsgICAgc21wX3JtYigpOwoKCnNtcF9tYigpIGFjdHVhbGx5PyBPciBpdCdz IGJldHRlciB0byBleHBsYWluIHRoaXMgZm9sbG93aW5nIHJlYWQgbmVlZHMgCnRvIGJlIG9yZGVy ZCB3aXRoIHdoYXQgcmVhZCBiZWZvcmUuCgpUaGFua3MKCgo+ICsgICAgaWYgKCEoc3ZxLT52cmlu Zy51c2VkLT5mbGFncyAmIFZSSU5HX1VTRURfRl9OT19OT1RJRlkpKSB7Cj4gKyAgICAgICAgZXZl bnRfbm90aWZpZXJfc2V0KCZzdnEtPmtpY2tfbm90aWZpZXIpOwo+ICsgICAgfQo+ICt9Cj4gKwo+ ICAgLyogSGFuZGxlIGd1ZXN0LT5kZXZpY2Ugbm90aWZpY2F0aW9ucyAqLwo+ICAgc3RhdGljIHZv aWQgdmhvc3RfaGFuZGxlX2d1ZXN0X2tpY2soRXZlbnROb3RpZmllciAqbikKPiAgIHsKPiBAQCAt MTc0LDcgKzE4Myw3IEBAIHN0YXRpYyB2b2lkIHZob3N0X2hhbmRsZV9ndWVzdF9raWNrKEV2ZW50 Tm90aWZpZXIgKm4pCj4gICAgICAgICAgICAgICB9Cj4gICAKPiAgICAgICAgICAgICAgIHZob3N0 X3NoYWRvd192cV9hZGQoc3ZxLCBlbGVtKTsKPiAtICAgICAgICAgICAgZXZlbnRfbm90aWZpZXJf c2V0KCZzdnEtPmtpY2tfbm90aWZpZXIpOwo+ICsgICAgICAgICAgICB2aG9zdF9zaGFkb3dfdnFf a2ljayhzdnEpOwo+ICAgICAgICAgICB9Cj4gICAKPiAgICAgICAgICAgdmlydGlvX3F1ZXVlX3Nl dF9ub3RpZmljYXRpb24oc3ZxLT52cSwgdHJ1ZSk7CgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBtYWlsaW5nIGxpc3QKVmlydHVh bGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZv dW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6YXRpb24=