Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]

On 11/12/2013 09:33 AM, Corey Minyard wrote:
> Allow a socket that connects to reconnect on a periodic basis if it
> fails to connect at startup or if the connection drops while in use.
> 
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
>  include/sysemu/char.h |  3 ++
>  qemu-char.c           | 88 ++++++++++++++++++++++++++++++++++++++++++++-------
>  qemu-options.hx       | 11 +++++--
>  3 files changed, 87 insertions(+), 15 deletions(-)
> 

> +++ b/qemu-options.hx
> @@ -1780,8 +1780,9 @@ ETEXI
>  DEF("chardev", HAS_ARG, QEMU_OPTION_chardev,
>      "-chardev null,id=id[,mux=on|off]\n"
>      "-chardev socket,id=id[,host=host],port=host[,to=to][,ipv4][,ipv6][,nodelay]\n"
> -    "         [,server][,nowait][,telnet][,mux=on|off] (tcp)\n"
> -    "-chardev socket,id=id,path=path[,server][,nowait][,telnet],[mux=on|off] (unix)\n"
> +    "         [,server][,nowait][,telnet][,mux=on|off][,reconnect=seconds] (tcp)\n"
> +    "-chardev socket,id=id,path=path[,server][,nowait][,telnet][,mux=on|off]\n"
> +    "         [,reconnect=seconds] (unix)\n"

> +@option{reconnect} specifies that if the socket does not come up at startup,
> +or if the socket is closed for some reason (like the other end exited),
> +wait the given number of seconds and attempt to reconnect.

Sounds cool.  Are you planning on also adding the QMP counterpart for
specifying this option when doing hotplugs of a chardev?  Does reconnect
make any sense when not using server mode?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]