From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH 1/2] hw/misc/bcm2835_property: Fix framebuffer with recent RPi kernels
Date: Sun, 17 Oct 2021 18:48:32 +1100 [thread overview]
Message-ID: <5283e2811498034cc2de77f10eb16b9cd67a0698.camel@kernel.crashing.org> (raw)
The framebuffer driver fails to initialize with recent Raspberry Pi
kernels, such as the ones shipped in the current RaspiOS images
(with the out of tree bcm2708_fb.c driver)
The reason is that this driver uses a new firmware call to query the
number of displays, and the fallback when this call fails is broken.
So implement the call and claim we have exactly one display
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
hw/misc/bcm2835_property.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
index 73941bdae9..b958fa6a5c 100644
--- a/hw/misc/bcm2835_property.c
+++ b/hw/misc/bcm2835_property.c
@@ -269,6 +269,10 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
stl_le_phys(&s->dma_as, value + 12, 0);
resplen = 4;
break;
+ case 0x00040013: /* Get num displays */
+ stl_le_phys(&s->dma_as, value + 12, 1);
+ resplen = 4;
+ break;
case 0x00060001: /* Get DMA channels */
/* channels 2-5 */
next reply other threads:[~2021-10-17 7:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 7:48 Benjamin Herrenschmidt [this message]
2021-10-17 15:08 ` [PATCH 1/2] hw/misc/bcm2835_property: Fix framebuffer with recent RPi kernels Philippe Mathieu-Daudé
2021-10-18 0:41 ` Benjamin Herrenschmidt
2021-10-18 9:47 ` Philippe Mathieu-Daudé
2021-10-18 10:27 ` Benjamin Herrenschmidt
2021-10-18 10:41 ` Philippe Mathieu-Daudé
2021-11-18 15:05 ` [PATCH-for-6.2 " Philippe Mathieu-Daudé
2022-01-17 12:13 ` Philippe Mathieu-Daudé via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5283e2811498034cc2de77f10eb16b9cd67a0698.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.