From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Vh0mb-00029u-9x
	for mharc-grub-devel@gnu.org; Thu, 14 Nov 2013 12:32:45 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39313)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1Vh0mQ-00029F-Vx
	for grub-devel@gnu.org; Thu, 14 Nov 2013 12:32:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1Vh0mI-0007ak-Iw
	for grub-devel@gnu.org; Thu, 14 Nov 2013 12:32:34 -0500
Received: from mail-we0-x232.google.com ([2a00:1450:400c:c03::232]:64237)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <phcoder@gmail.com>) id 1Vh0mI-0007aV-BM
	for grub-devel@gnu.org; Thu, 14 Nov 2013 12:32:26 -0500
Received: by mail-we0-f178.google.com with SMTP id u57so1869714wes.37
	for <grub-devel@gnu.org>; Thu, 14 Nov 2013 09:32:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type;
	bh=nRLdsZjEYZrLTXk+j03xlit4jvKZ7YUZl7ssfD+8lnY=;
	b=HBfIWghlLPJi5Uvja2ZyowCiRUip2Ib43/1xz4e/IzO4MeH8drp96niar607901Vks
	PWGaPO4jh6JYZMaW5mXweZmBcakIbX3N1PyGaDp5mlj4vcMHmkmSkZt87onHQ5kMwJ2y
	gmVkGEmJYP0ddwdSck5bUq5//OwCE2G0VU/JsTADM0gjKYBrZje0OZAhr4ul8RS1fEm2
	fk8opnyjTCPJSamNMUAD1ZJ0gmXVp2Rkwq8vhcBXdKqxWQgD77yFcZjp/i/E58Hv14cC
	1wdeqmtaffMlBLljUh1oOibtFpNdXCnlKIbUNkHaZFFvyfZy7htRG3FXmHJglqdfc51V
	yLnw==
X-Received: by 10.180.212.51 with SMTP id nh19mr3798690wic.52.1384450344740;
	Thu, 14 Nov 2013 09:32:24 -0800 (PST)
Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31])
	by mx.google.com with ESMTPSA id o47sm1553993eem.21.2013.11.14.09.32.23
	for <multiple recipients>
	(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
	Thu, 14 Nov 2013 09:32:23 -0800 (PST)
Message-ID: <52850918.1040406@gmail.com>
Date: Thu, 14 Nov 2013 18:32:08 +0100
From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?=
	<phcoder@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:17.0) Gecko/20131005 Icedove/17.0.9
MIME-Version: 1.0
To: M A Young <m.a.young@durham.ac.uk>
Subject: Re: [Xen-devel] pvgrub2 is merged
References: <527EA084.6000706@gmail.com>
	<20131110084753.540b0107@opensuse.site>
	<alpine.DEB.2.00.1311131848160.27356@procyon.dur.ac.uk>
	<5283DD8F.5080103@gmail.com>
	<alpine.DEB.2.00.1311141213350.11266@procyon.dur.ac.uk>
	<alpine.DEB.2.00.1311141657530.28334@procyon.dur.ac.uk>
In-Reply-To: <alpine.DEB.2.00.1311141657530.28334@procyon.dur.ac.uk>
X-Enigmail-Version: 1.5.1
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature";
	boundary="----enig2OOCSQLEGTXOQPJCMLIRB"
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
	(bad octet value).
X-Received-From: 2a00:1450:400c:c03::232
Cc: The development of GNU GRUB <grub-devel@gnu.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Nov 2013 17:32:43 -0000

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2OOCSQLEGTXOQPJCMLIRB
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 14.11.2013 18:03, M A Young wrote:
>=20
>=20
> On Thu, 14 Nov 2013, M A Young wrote:
>=20
>> On Wed, 13 Nov 2013, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote:=

>>
>>> On 13.11.2013 20:06, M A Young wrote:
>>>> It doesn't seem to understand sub-partitions. I can get it to work i=
f
>>>> the boot files are in /dev/xvda but not in /dev/xvda1 .
>>>>
>>> insmod part_msdos
>>> insmod part_gpt
>>
>> Right, if I add those to the embedded grub.cfg file I get to the
>> standard grub menu and the boot starts. However the boot doesn't get
>> very far - it loads the kernel and the initrd file and starts the
>> kernel but the kernel doesn't see the virtual disks so it doesn't get
>> very far.
>=20
> Using xenstore-ls from the dom0 on the guest when the boot stops the
> local/domain/2/device/vbd/51712 section looks like
>       backend =3D "/local/domain/0/backend/vbd/2/51712"
>       backend-id =3D "0"
>       state =3D "6\000"
>       virtual-device =3D "51712"
>       device-type =3D "disk"
>       ring-ref =3D "\000"
>       event-channel =3D "\000"
>       protocol =3D "x86_64-abi\000"
>=20
> As nothing else has null character endings I suspend that is wrong.
>=20
Good catch. Could you test following:
diff --git a/grub-core/kern/xen/init.c b/grub-core/kern/xen/init.c
index 3bfd99f..ab74543 100644
--- a/grub-core/kern/xen/init.c
+++ b/grub-core/kern/xen/init.c
@@ -256,11 +256,10 @@ grub_xenstore_write_file (const char *dir, const vo=
id *buf, grub_size_t len)
=20
   grub_memset (&msg, 0, sizeof (msg));
   msg.type =3D XS_WRITE;
-  msg.len =3D dirlen + len + 1;
+  msg.len =3D dirlen + len;
   grub_xen_store_send (&msg, sizeof (msg));
   grub_xen_store_send (dir, dirlen);
   grub_xen_store_send (buf, len);
-  grub_xen_store_send ("", 1);
   grub_xen_store_recv (&msg, sizeof (msg));
   resp =3D grub_malloc (msg.len + 1);
   if (!resp)

>     Michael Young



------enig2OOCSQLEGTXOQPJCMLIRB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Using GnuPG with Icedove - http://www.enigmail.net/

iF4EAREKAAYFAlKFCScACgkQmBXlbbo5nOuNUQEAkhgDKVYnSdhIJGcXhu6fq6tK
sU6dxr9ytLJDBwM/+vYA+gKD+n67g33oiT3sjjLuQ1Sm1OXGkj6DHf+ofmAYAZSm
=fD36
-----END PGP SIGNATURE-----

------enig2OOCSQLEGTXOQPJCMLIRB--