From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH RFC v2] pvh: clearly specify used parameters in vcpu_guest_context Date: Tue, 19 Nov 2013 11:42:24 +0100 Message-ID: <528B4090.40608@citrix.com> References: <1384798711-4255-1-git-send-email-roger.pau@citrix.com> <528B3EA3.9090008@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ViilM-0001CD-AZ for xen-devel@lists.xenproject.org; Tue, 19 Nov 2013 10:42:32 +0000 In-Reply-To: <528B3EA3.9090008@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: xen-devel@lists.xenproject.org, Keir Fraser , Tim Deegan , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gMTkvMTEvMTMgMTE6MzQsIEdlb3JnZSBEdW5sYXAgd3JvdGU6Cj4gT24gMTEvMTgvMjAxMyAw NjoxOCBQTSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOgo+PiBUaGUgYWltIG9mIHRoaXMgcGF0Y2gg aXMgdG8gZGVmaW5lIGEgc3RhYmxlIHdheSBpbiB3aGljaCBQVkggaXMKPj4gZ29pbmcgdG8gZG8g QVAgYnJpbmd1cC4KPj4KPj4gU2luY2Ugd2UgYXJlIHJ1bm5pbmcgaW5zaWRlIG9mIGEgSFZNIGNv bnRhaW5lciwgUFZIIHNob3VsZCBvbmx5IG5lZWQKPj4gdG8gc2V0IGZsYWdzLCBjcjMgYW5kIHVz ZXJfcmVncyBpbiBvcmRlciB0byBicmluZyB1cCBhIHZDUFUsIHRoZSByZXN0Cj4+IGNhbiBiZSBz ZXQgb25jZSB0aGUgdkNQVSBpcyBzdGFydGVkIHVzaW5nIHRoZSBiYXJlIG1ldGFsIG1ldGhvZHMu Cj4+IEFkZGl0aW9uYWxseSwgdGhlIGd1ZXN0IGNhbiBhbHNvIHNldCBjcjAgYW5kIGNyNCwgYW5k IHRob3NlIHZhbHVlcwo+PiB3aWxsIGJlIGFwcGVuZGVkIHRvIHRoZSBkZWZhdWx0IHZhbHVlcyBz ZXQgYnkgWGVuLgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5w YXVAY2l0cml4LmNvbT4KPj4gQ2M6IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAZXUuY2l0 cml4LmNvbT4KPj4gQ2M6IE11a2VzaCBSYXRob3IgPG11a2VzaC5yYXRob3JAb3JhY2xlLmNvbT4K Pj4gQ2M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4KPj4gQ2M6IFRpbSBEZWVnYW4g PHRpbUB4ZW4ub3JnPgo+PiBDYzogS2VpciBGcmFzZXIgPGtlaXJAeGVuLm9yZz4KPj4gLS0tCj4+ ICAgeGVuL2FyY2gveDg2L2RvbWFpbi5jICAgICAgICAgICAgIHwgICAyNCArKysrKysrKysrKysr KysrLS0tLS0tLS0KPj4gICB4ZW4vYXJjaC94ODYvaHZtL3ZteC92bXguYyAgICAgICAgfCAgICA2 ICstLS0tLQo+PiAgIHhlbi9pbmNsdWRlL2FzbS14ODYvaHZtL2h2bS5oICAgICB8ICAgIDYgKysr LS0tCj4+ICAgeGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L3hlbi5oIHwgICAgOCArKysrLS0t LQo+PiAgIDQgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMjAgZGVsZXRpb25zKC0p Cj4+Cj4+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvZG9tYWluLmMgYi94ZW4vYXJjaC94ODYv ZG9tYWluLmMKPj4gaW5kZXggYTM4NjhmOS4uNTEzMTFmYyAxMDA2NDQKPj4gLS0tIGEveGVuL2Fy Y2gveDg2L2RvbWFpbi5jCj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9kb21haW4uYwo+PiBAQCAtNTEs NiArNTEsNyBAQAo+PiAgICNpbmNsdWRlIDxhc20vZml4bWFwLmg+Cj4+ICAgI2luY2x1ZGUgPGFz bS9odm0vaHZtLmg+Cj4+ICAgI2luY2x1ZGUgPGFzbS9odm0vc3VwcG9ydC5oPgo+PiArI2luY2x1 ZGUgPGFzbS9odm0vbmVzdGVkaHZtLmg+Cj4+ICAgI2luY2x1ZGUgPGFzbS9kZWJ1Z3JlZy5oPgo+ PiAgICNpbmNsdWRlIDxhc20vbXNyLmg+Cj4+ICAgI2luY2x1ZGUgPGFzbS90cmFwcy5oPgo+PiBA QCAtNzA0LDkgKzcwNSwxMyBAQCBpbnQgYXJjaF9zZXRfaW5mb19ndWVzdCgKPj4gICAgICAgICAg IC8qIFBWSCAzMmJpdGZpeG1lICovCj4+ICAgICAgICAgICBBU1NFUlQoIWNvbXBhdCk7Cj4+Cj4+ IC0gICAgICAgIGlmICggYyhjdHJscmVnWzFdKSB8fCBjKGxkdF9iYXNlKSB8fCBjKGxkdF9lbnRz KSB8fAo+PiArICAgICAgICBpZiAoIChjKGN0cmxyZWdbMF0pICYgSFZNX0NSMF9HVUVTVF9SRVNF UlZFRF9CSVRTKSB8fAo+PiArICAgICAgICAgICAgIChjKGN0cmxyZWdbNF0pICYgSFZNX0NSNF9H VUVTVF9SRVNFUlZFRF9CSVRTKHYpKSB8fAo+IAo+IEdvb2QgaWRlYS4gOi0pCj4gCj4+ICsgICAg ICAgICAgICAgYyhjdHJscmVnWzFdKSB8fCBjKGN0cmxyZWdbMl0pIHx8IGMoY3RybHJlZ1s1XSkg fHwKPj4gKyAgICAgICAgICAgICBjKGN0cmxyZWdbNl0pIHx8IGMoY3RybHJlZ1s3XSkgfHwgYyhs ZHRfYmFzZSkgfHwKPj4gYyhsZHRfZW50cykgfHwKPj4gICAgICAgICAgICAgICAgYyh1c2VyX3Jl Z3MuY3MpIHx8IGModXNlcl9yZWdzLnNzKSB8fCBjKHVzZXJfcmVncy5lcykgfHwKPj4gICAgICAg ICAgICAgICAgYyh1c2VyX3JlZ3MuZHMpIHx8IGModXNlcl9yZWdzLmZzKSB8fCBjKHVzZXJfcmVn cy5ncykgfHwKPj4gKyAgICAgICAgICAgICBjKGtlcm5lbF9zcykgfHwgYyhrZXJuZWxfc3ApIHx8 IGMubmF0LT5nc19iYXNlX2tlcm5lbCB8fAo+PiAgICAgICAgICAgICAgICBjLm5hdC0+Z2R0X2Vu dHMgfHwgYy5uYXQtPmZzX2Jhc2UgfHwgYy5uYXQtPmdzX2Jhc2VfdXNlciApCj4+ICAgICAgICAg ICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4+ICAgICAgIH0KPj4gQEAgLTc0NSwxNyArNzUwLDIwIEBA IGludCBhcmNoX3NldF9pbmZvX2d1ZXN0KAo+Pgo+PiAgICAgICBpZiAoIGhhc19odm1fY29udGFp bmVyX3ZjcHUodikgKQo+PiAgICAgICB7Cj4+IC0gICAgICAgIC8qCj4+IC0gICAgICAgICAqIE5C OiBURl9rZXJuZWxfbW9kZSBpcyBzZXQgdW5jb25kaXRpb25hbGx5IGZvciBIVk0gZ3Vlc3RzLAo+ PiAtICAgICAgICAgKiBzbyB3ZSBhbHdheXMgdXNlIHRoZSBnc19iYXNlX2tlcm5lbCBoZXJlLiBJ ZiB3ZSBjaGFuZ2UgdGhpcwo+PiAtICAgICAgICAgKiBmdW5jdGlvbiB0byBpbWl0YXRlIHRoZSBQ ViBmdW5jdGlvbmFsaXR5LCB3ZSdsbCBuZWVkIHRvCj4+IC0gICAgICAgICAqIG1ha2UgaXQgcGF5 IGF0dGVudGlvbiB0byB0aGUga2VybmVsIGJpdC4KPj4gLSAgICAgICAgICovCj4+IC0gICAgICAg IGh2bV9zZXRfaW5mb19ndWVzdCh2LCBjb21wYXQgPyAwIDogYy5uYXQtPmdzX2Jhc2Vfa2VybmVs KTsKPiAKPiBJIHRoaW5rIHdlIHN0aWxsIG5lZWQgdG8gY2FsbCBodm1fc2V0X2luZm9fZ3Vlc3Qo KSBoZXJlIC0tIHRoZXJlIGlzCj4gb3RoZXIgc3R1ZmYgYmVpbmcgc2V0IHVwLCBhbmQgaXQgd2Fz IGNhbGxlZCAod2l0aG91dCB0aGUgZXh0cmEgYXJndW1lbnQKPiBmb3IgZ3NfYmFzZV9rZXJuZWwp IGJlZm9yZSB0aGUgUFZIIHBhdGNoIHNlcmllcyB3ZW50IGluLgo+IAo+IChTZWUgYy9zIDM1YjFl MDcuKQoKSSBzZWUsIEkgd2lsbCByZXN0b3JlIHRoZSBodm1fc2V0X2luZm9fZ3Vlc3QgY2FsbCwg Z29vZCBjYXRjaC4KCj4gCj4+Cj4+ICAgICAgICAgICBpZiAoIGlzX2h2bV92Y3B1KHYpIHx8IHYt PmlzX2luaXRpYWxpc2VkICkKPj4gICAgICAgICAgICAgICBnb3RvIG91dDsKPj4KPj4gKyAgICAg ICAgaWYgKCBjLm5hdC0+Y3RybHJlZ1swXSApIHsKPj4gKyAgICAgICAgICAgIHYtPmFyY2guaHZt X3ZjcHUuZ3Vlc3RfY3JbMF0gfD0gYy5uYXQtPmN0cmxyZWdbMF07Cj4+ICsgICAgICAgICAgICBo dm1fdXBkYXRlX2d1ZXN0X2NyKHYsIDApOwo+PiArICAgICAgICB9Cj4+ICsKPj4gKyAgICAgICAg aWYgKCBjLm5hdC0+Y3RybHJlZ1s0XSApIHsKPj4gKyAgICAgICAgICAgIHYtPmFyY2guaHZtX3Zj cHUuZ3Vlc3RfY3JbNF0gfD0gYy5uYXQtPmN0cmxyZWdbNF07Cj4+ICsgICAgICAgICAgICBodm1f dXBkYXRlX2d1ZXN0X2NyKHYsIDQpOwo+PiArICAgICAgICB9Cj4gCj4gSSB0aG91Z2h0IHRoZSBp ZGVhIHdhcyB0aGF0IGhlIHdvdWxkIHNldCBjcjAsIGNyMywgYW5kIGNyNCBmb3IgYWxsIEhWTQo+ IGd1ZXN0cywgcmF0aGVyIHRoYW4gc3BlY2lhbC1jYXNpbmcgUFZIIGd1ZXN0cz8KCldlbGwsIEkg d2FzIGp1c3QgdHJ5aW5nIHRvIG1ha2UgdGhlIFBWSCBBUCBicmluZ3VwIGludGVyZmFjZSBzdGFi bGUsCndpdGhvdXQgbWVzc2luZyBtdWNoIHdpdGggSFZNIChub3QgdGhhdCB3ZSBzaG91bGRuJ3Qg YWltIHRvIGRvIGl0IGZvcgpIVk0gZ3Vlc3RzIGFsc28pLCBidXQgSSB0aGluayB0aGUgbWFpbiBj b25jZXJuIG5vdyBpcyByZWxlYXNpbmcgNC40IHdpdGgKYSBzdGFibGUgaW50ZXJmYWNlIGZvciBQ VkggZ3Vlc3RzLgoKVGhhbmtzLCBSb2dlci4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0 cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=